[Bug 32484] New: Enable framework plugins when UseACQFrameworkForBiblioRecords is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Bug ID: 32484 Summary: Enable framework plugins when UseACQFrameworkForBiblioRecords is set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 144690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144690&action=edit Bug 32484: Enable plugins when UseACQFrameworkForBiblioRecords is set Test plan: 1. Do not apply the patch yet 2. Make sure you have an ACQ biblio framework with some framework plugins enabled. Create it if you don't. 3. Enable UseACQFrameworkForBiblioRecords system preference 4. Create a new acquisition basket. 5. On this new basket, click on "+ Add to basket", then "From a new (empty) record" 6. You should see a simplified MARC editor based on ACQ framework. Confirm that the plugins are not enabled (no visible buttons, nothing happening on focus/blur) 7. Apply patch 8. Repeat step 5 9. You should now see the plugins' buttons (only if you enabled plugins that use the 'click' event) 10. Confirm that the enabled plugins work correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31582 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144690|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 144706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144706&action=edit Bug 32484: Enable plugins when UseACQFrameworkForBiblioRecords is set Test plan: 1. Do not apply the patch yet 2. Make sure you have an ACQ biblio framework with some framework plugins enabled. Create it if you don't. 3. Enable UseACQFrameworkForBiblioRecords system preference 4. Create a new acquisition basket. 5. On this new basket, click on "+ Add to basket", then "From a new (empty) record" 6. You should see a simplified MARC editor based on ACQ framework. Confirm that the plugins are not enabled (no visible buttons, nothing happening on focus/blur) 7. Apply patch 8. Repeat step 5 9. You should now see the plugins' buttons (only if you enabled plugins that use the 'click' event) 10. Confirm that the enabled plugins work correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement enables release notes| |the use of framework | |plugins when: | |- | |UseACQFrameworkForBiblioRec | |ords is enabled, and | |- | |entering catalog details | |when adding items to a | |basket from a new (empty) | |record. | |This requires | |plugins to be enabled for | |fields in the ACQ | |framework. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. MARC21 doesn't have as many framework plugins as UNIMARC. 2. I tested as follows - hope this is sufficient: 2.1 Using the 'Fixed length control field (00000)': before the patch is applied it is automatically generated, but you can't select any options - after the patch you can select options. 2.2 Added 005 (Date and time of last transaction) to the ACQ framework and used the marc21_field_005.pl plugin: before the patch is applied there is no value automatically applied to the field, after the patch is applied you can click on the field and it is populated. 3. The catalog details label width is very narrow - I think this should be widened, as was done as an exception for the item fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31536 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) FAIL t/db_dependent/Koha/UI/Form/Builder/Biblio.t FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 36) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 147298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147298&action=edit Bug 32484: Replace DateTime->now by Koha::DateUtils::dt_from_string -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Marcel de Rooy from comment #4)
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) Framework plugins do not work when all script tags are at the end of <body>. That's why I moved them inside <head>
FAIL t/db_dependent/Koha/UI/Form/Builder/Biblio.t FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 36) Fixed by the last patch
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha/UI/Form/Builder/Biblio.pm | 372 +++++++++++++++ acqui/neworderempty.pl | 60 ++- cataloguing/addbiblio.pl | 350 +++----------- .../prog/en/modules/acqui/neworderempty.tt | 444 +++++++++--------- koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 3 +- t/db_dependent/Koha/UI/Form/Builder/Biblio.t | 182 +++++++ Could you explain why we need to move so much code here? Hard to catch bugs in such refactoring ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Trust me, I don't move code for fun :) I needed to reuse the code from addbiblio.pl in neworderempty.pl so I moved it into a Koha:: module, that's it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This test ( $applydefaults =~ /changed/ && $changed_framework ) || wont work for default fw but currently we focus here on ACQ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144706|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149798&action=edit Bug 32484: Enable plugins when UseACQFrameworkForBiblioRecords is set Test plan: 1. Do not apply the patch yet 2. Make sure you have an ACQ biblio framework with some framework plugins enabled. Create it if you don't. 3. Enable UseACQFrameworkForBiblioRecords system preference 4. Create a new acquisition basket. 5. On this new basket, click on "+ Add to basket", then "From a new (empty) record" 6. You should see a simplified MARC editor based on ACQ framework. Confirm that the plugins are not enabled (no visible buttons, nothing happening on focus/blur) 7. Apply patch 8. Repeat step 5 9. You should now see the plugins' buttons (only if you enabled plugins that use the 'click' event) 10. Confirm that the enabled plugins work correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147298|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149799&action=edit Bug 32484: Replace DateTime->now by Koha::DateUtils::dt_from_string Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149800&action=edit Bug 32484: (QA follow-up) Fixes to POD Resolve: FAIL Koha/UI/Form/Builder/Biblio.pm FAIL pod coverage POD is missing for build_authorized_values_list POD is missing for create_key Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149801&action=edit Bug 32484: (QA follow-up) Polishing unit test Test plan, removed done_testing. License. Since we are in t/db, good to add transaction, although we currently do not change anything here. But who knows? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 149802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149802&action=edit Bug 32484: (QA follow-up) Few typos Test plan: Run git grep "specifique key" Run git grep "the fonction" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Thank you Marcel for the QA and the follow-ups :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 31582 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It appears that this fixed bug 31582. Any chance we could reasonably consider this for backporting maybe? This will also help immensely in not creating false record with missing LDR etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed as requested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This enhancement enables release notes|the use of framework |the use of framework |plugins when: |plugins when: |- |- |UseACQFrameworkForBiblioRec |`UseACQFrameworkForBiblioRe |ords is enabled, and |cords` is enabled, and |- |- |entering catalog details |entering catalog details |when adding items to a |when adding items to a |basket from a new (empty) |basket from a new (empty) |record. |record. |This requires |This requires |plugins to be enabled for |plugins to be enabled for |fields in the ACQ |fields in the `ACQ` |framework. |framework. Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement enables |This bugfix enables the use release notes|the use of framework |of framework plugins when: |plugins when: |- |- |`UseACQFrameworkForBiblioRe |`UseACQFrameworkForBiblioRe |cords` is enabled, and |cords` is enabled, and |- |- |entering catalog details |entering catalog details |when adding items to a |when adding items to a |basket from a new (empty) |basket from a new (empty) |record. |record. |This requires |This requires |plugins to be enabled for |plugins to be enabled for |fields in the `ACQ` |fields in the `ACQ` |framework. |framework. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34993 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34993 [Bug 34993] Framework don't load in existing records or duplicate as new -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org