[Bug 16547] New: Can't place item level hold directly from search results screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Bug ID: 16547 Summary: Can't place item level hold directly from search results screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you search for an item that brings up a list of results, checking the check box and clicking the 'Place Hold' button allows you to place a hold -- but after you've selected the patron, you can only place biblio level holds -- the section of the 'Confirm Holds' page which usually shows to allow item level holds is not displayed. This is most easily demonstrated on the bywater demo machine [usernam and password are both koha]. Search for Harry Potter: http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=harr... Click the check-box for the first search result ( Harry Potter and the Chamber of Secrets [videorecording] ... ) Click the 'Place hold' button, which will take you to the 'Confirm hold' screen (http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblionumbers=25778%2F&findborrower=&multi_hold=1) Enter card number 55. This takes you to a second 'Confirm hold' screen, showing a hold for 'Harry Potter and the Chamber of Secrets' for patron Bilbo Baggins (55)... no item information is viewable. (http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblion...) By contrast, If I start at http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=harr..., and click in to the first result page to see the details: http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=25778&searchid=scs_1463601092892 Then click 'place hold' from the details screen, I am taken to http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblionumber=25778&searchid=scs_1463601092892 Entering card number 55 at that point takes me to http://intranet.bywatersolutions.com/cgi-bin/koha/reserve/request.pl?biblion... ... but this time item level information *is* available, and an item level hold can be placed. Steps to replicate on your system: 1/ Search for an item with more than one search result 2/ Select an item, click 'Place hold' 3/ Enter a patron card number 4/ Note that item level holds are not available. 5/ Run the search again 6/ Click the title to see the detail page on the same bib. 7/ Enter the same patron card number 8/ Items now show on the page, and an item level hold can be placed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- 16:11 < cait> barton: koha doesn't work as login fro me to check out your latest bug 16:13 < barton> ok, I'll check that. 16:13 < barton> thanks. 16:14 < barton> cait: sorry, it's bywater/bywater. I'll update the bug. 16:14 < cait> aah :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's by design, with multi holds the next available item is automatically selected. I'd say this is more an enhancement request than a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could send the user to the normal holds page if only one record was selected? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97296&action=edit Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- Patch no longer applies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97296|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99072&action=edit Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99072|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 99121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99121&action=edit Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99121|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101992&action=edit Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101992|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 102002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102002&action=edit Bug 16547: Do not display "multi holds" view if only one is selected If a hold is selected from the result list, we should let the ability to select an item-level hold. Test plan: I. Detail page 1/ Go to a bibliographic record detail page 2/ Click "Place hold" 3/ Select a patron => No change expected, you can select an item II. Search result, multiple holds 1/ Search for an item with more than one search result 2/ Select several items, click 'Place hold' 3/ Enter a patron card number => No change expected, item level holds are not available. III. Search result, single hold 1/ Search for an item with more than one search result 2/ Select only one item, click 'Place hold' 3/ Enter a patron card number => With this patch applied, item level hold is available. The screen is the same as when you place a hold from the bibliographic record detail page => Without this patch you cannot place an item-level hold QA notes: We could go a bit further and remove the 2 biblionumbers and biblionumber from hold script, as well as remove the checkMultiHold in request.tt. We should not have a biblionumbers param that contain a list of biblionumber separated by '/' but several biblionumber parameters instead. QA notes 2: About placerequest.pl, see bug 19618 comment 27. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement lets you release notes| |place and an item level | |hold from a search results | |list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102570&action=edit Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= https://bugs.koha-community.org/show_bug.cgi?id=24547 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102570|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102571&action=edit Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Quick test plan for Jonathan's patch: 1 perform search that returns multiple titles 2 select two titles and click Place Hold from results page 3 select patron 4 change pickup location, click Place Hold 5 get taken to page that says "Place hold on No Title" 6 look at the two titles you'd meant to place holds on -- holds do place, but we don't get any confirmation screen 7 apply patch 8 repeat steps 1-4 9 get taken to Confirm Holds page that lists the titles on which you just placed holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102571|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 102573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102573&action=edit Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102573|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 102608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102608&action=edit Bug 16547: Remove more multi_holds inconsistencies There was a bug, on the biblio's hold list view, if the pickup library was changed, the next screen was "place a hold for no title" http://pro.kohadev.org/cgi-bin/koha/reserve/request.pl?multi_hold=1&biblionumbers= Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks Andrew and Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #17 from Joy Nelson <joy@bywatersolutions.com> --- enhancement no backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25408 CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- Jonathan, Can the work you've done here be applied to the cart? If so, I could create a ticket suggesting that enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Christopher Brannon from comment #19)
Jonathan, Can the work you've done here be applied to the cart? If so, I could create a ticket suggesting that enhancement.
What exactly? I have tested on master and I see the item info for a single hold and the "multi holds view" if more than 1 is selected. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org