https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129749&action=edit Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129749|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129835&action=edit Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129835|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129890&action=edit Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Consider my stamp a PQA if someone else tests this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26019 [Bug 26019] Koha should set SameSite attribute on cookies -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129890|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 131838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131838&action=edit Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)

Consider my stamp a PQA if someone else tests this.

Haha -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29940 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.