[Bug 35119] New: Make bibliographic errors more prominent and match current styling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Bug ID: 35119 Summary: Make bibliographic errors more prominent and match current styling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 35099 Currently, the encoding errors and analytics search error warnings are outside of the normal page flow and they could be more prominent using a bg-warning coloured page-section. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099 [Bug 35099] Cannot load records with invalid marcxml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157529&action=edit Bug 35119: Use page-section and bg-danger on biblio errors This patch uses the page-section and bg-danger classes to increase the prominence of bibliographic record errors in the staff client to encourage staff to fix such issues as soon as possible. Test plan 1) Using ktd navigate to record 369 2) Note the display of an encoding warning at the top of the page 3) Apply the patch 4) Refresh the above page and note the stronger visual prominence of the error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I feel like we should be able to do better with the encode error itself too.. it's all on one line as it displays right now.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157529|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157538&action=edit Bug 35119: Use page-section and bg-danger on biblio errors This patch uses the page-section and bg-danger classes to increase the prominence of bibliographic record errors in the staff client to encourage staff to fix such issues as soon as possible. We also output the actual encoding error in a <pre> block to maintain the proper whitespacing of the errors themselves.. this makes it much clearer which characters are the issues. Test plan 1) Using ktd navigate to record 369 2) Note the display of an encoding warning at the top of the page 3) Apply the patch 4) Refresh the above page and note the stronger visual prominence of the error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Much better.. the errors are now super clear! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34014 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157538|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 157553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157553&action=edit Bug 35119: Use page-section and bg-danger on biblio errors This patch uses the page-section and bg-danger classes to increase the prominence of bibliographic record errors in the staff client to encourage staff to fix such issues as soon as possible. We also output the actual encoding error in a <pre> block to maintain the proper whitespacing of the errors themselves.. this makes it much clearer which characters are the issues. Test plan 1) Using ktd navigate to record 369 2) Note the display of an encoding warning at the top of the page 3) Apply the patch 4) Refresh the above page and note the stronger visual prominence of the error Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157561&action=edit Bug 35119: (follow-up) Same treatment for editor page We pushed 34014 before I thought about these changes.. I think this is a solid follow-up to add the same styling to the catalogue editor page.. swapping the existing dialog alert with a page-section bg-danger and thus allowing more space to 'pre' wrap the encoding error itself to ease the spotting of errant characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157553|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157577&action=edit Bug 35119: Use page-section and bg-danger on biblio errors This patch uses the page-section and bg-danger classes to increase the prominence of bibliographic record errors in the staff client to encourage staff to fix such issues as soon as possible. We also output the actual encoding error in a <pre> block to maintain the proper whitespacing of the errors themselves.. this makes it much clearer which characters are the issues. Test plan 1) Using ktd navigate to record 369 2) Note the display of an encoding warning at the top of the page 3) Apply the patch 4) Refresh the above page and note the stronger visual prominence of the error Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157561|0 |1 is obsolete| | --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157578&action=edit Bug 35119: (follow-up) Same treatment for editor page We pushed 34014 before I thought about these changes.. I think this is a solid follow-up to add the same styling to the catalogue editor page.. swapping the existing dialog alert with a page-section bg-danger and thus allowing more space to 'pre' wrap the encoding error itself to ease the spotting of errant characters. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Tempting to say we should amend the message shown in the advanced editor to something like "please see logs, or just switch to the basic editor where we'll actually show you the errors." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 [Bug 34014] There is no way to fix records with broken MARCXML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157641&action=edit Bug 35119: (follow-up) Adapt advanced editor message I'd love to have included the error details within the message popup, but that alluded me so this patch just updates the message to hint that details can be seen on the basic editor screen. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife@ptfs-europe. | |com, | |jake.deery@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157577|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157643&action=edit Bug 35119: Use page-section and bg-danger on biblio errors This patch uses the page-section and bg-danger classes to increase the prominence of bibliographic record errors in the staff client to encourage staff to fix such issues as soon as possible. We also output the actual encoding error in a <pre> block to maintain the proper whitespacing of the errors themselves.. this makes it much clearer which characters are the issues. Test plan 1) Using ktd navigate to record 369 2) Note the display of an encoding warning at the top of the page 3) Apply the patch 4) Refresh the above page and note the stronger visual prominence of the error Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157578|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157644&action=edit Bug 35119: (follow-up) Same treatment for editor page We pushed 34014 before I thought about these changes.. I think this is a solid follow-up to add the same styling to the catalogue editor page.. swapping the existing dialog alert with a page-section bg-danger and thus allowing more space to 'pre' wrap the encoding error itself to ease the spotting of errant characters. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157641|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157645&action=edit Bug 35119: (follow-up) Adapt advanced editor message I'd love to have included the error details within the message popup, but that alluded me so this patch just updates the message to hint that details can be seen on the basic editor screen. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Bug 35119 depends on bug 35099, which changed state. Bug 35099 Summary: Cannot load records with invalid marcxml https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35099 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35099 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This seems to have broken some selenium tests. Please fix ASAP. https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testRe... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157984&action=edit Bug 35119: Add back classes used for selenium tests This patch re-instates the classes used for the selenium tests.. I checked we weren't using them for javascript or css, but didn't think about tests before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157984|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157985&action=edit Bug 35119: Add back classes used for selenium tests This patch re-instates the classes used for the selenium tests.. I checked we weren't using them for javascript or css, but didn't think about tests before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Bug 35119 depends on bug 34014, which changed state. Bug 34014 Summary: There is no way to fix records with broken MARCXML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make bibliographic errors |Make bibliographic encoding |more prominent and match |errors more prominent and |current styling |match current styling -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35119 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Staff interface CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org