[Bug 32394] New: Long tasks queue is never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Bug ID: 32394 Summary: Long tasks queue is never used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 27783 We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27783 [Bug 27783] Introduce background job queues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Aren't the parameter confusing but the outcome correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This one could be considered critical actually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144400&action=edit Bug 32394: Restore long tasks queue We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Test plan: Read code and confirm the above. More fun for test plan will be found on bug 32393 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #1)
Aren't the parameter confusing but the outcome correct?
All jobs are using the default queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32393 [Bug 32393] background job worker explodes if JSON is incorrect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #4)
All jobs are using the default queue.
I thought ES indexing was supposed to use the long one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)
(In reply to Jonathan Druart from comment #4)
All jobs are using the default queue.
I thought ES indexing was supposed to use the long one?
Maybe I had that backwards. I see now on the patch... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate, | |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144400|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144444&action=edit Bug 32394: Restore long tasks queue We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Test plan: Read code and confirm the above. More fun for test plan will be found on bug 32393 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- prove t/db_dependent/Koha/BackgroundJob* t/db_dependent/Koha/BackgroundJob.t ...................... ok t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t ... ok t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t ..... ok t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t ... ok t/db_dependent/Koha/BackgroundJobs/StageMARCForImport.t .. ok t/db_dependent/Koha/BackgroundJobs.t ..................... ok All tests successful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144444|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 144524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144524&action=edit Bug 32394: Restore long tasks queue We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Test plan: Read code and confirm the above. More fun for test plan will be found on bug 32393 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Warning for the RM: trivial fix but module changes without unit tests ;) This got perhaps unnoticed since we didnt test ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I will provide tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #10)
Warning for the RM: trivial fix but module changes without unit tests ;) This got perhaps unnoticed since we didnt test ?
Thanks. My plan was to provide the tests on pushing. But better fail it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144567&action=edit Bug 32394: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144567|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144568&action=edit Bug 32394: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144568|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144585&action=edit Bug 32394: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144586&action=edit Bug 32394: Restore long tasks queue We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Test plan: Read code and confirm the above. More fun for test plan will be found on bug 32393 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144587&action=edit Bug 32394: Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.01 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144670&action=edit Bug 32394: (follow-up) Add param for Koha::BackgroundJob::StageMARCForImport->enqueue Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01 |23.05.00,22.11.01,22.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- This doesn't apply cleanly to 22.05.x, if needed please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01,22.11.01 |23.05.00,22.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145964&action=edit Bug 32394: [22.05.x] Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145965&action=edit Bug 32394: [22.05.x] Restore long tasks queue We are sending "queue" as parameter, but "job_queue" is retrieved in Koha::BackgroundJob->enqueue... Test plan: Read code and confirm the above. More fun for test plan will be found on bug 32393 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145966&action=edit Bug 32394: [22.05.x] Add tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I have not tested the rebase! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #26)
I have not tested the rebase!
Thanks Jonathan, it seems to work but I'd like one more sign-off besides my own before I push to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #26)
I have not tested the rebase!
Tomas and I tested the rebase together and everything is good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01 |23.05.00,22.11.01,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32394 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |arthur.suzuki@biblibre.com --- Comment #30 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- depends on 27783, can't applied on 21.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org