[Bug 10037] New: correct item index in UNIMARC DOM indexing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Bug ID: 10037 Summary: correct item index in UNIMARC DOM indexing Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr In UNIMARC DOM config file (biblio-zebra-indexdefs.xsl), we have this line <z:index name="item # just to index every subfield:w"> I suppose it is not good... We should remove the comments M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|correct item index in |fix item index in UNIMARC |UNIMARC DOM indexing |DOM indexing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 17495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17495&action=edit [PATCH] Bug 10037 : item index is broken in UNIMARC DOM indexing In UNIMARC DOM indexing, "item" index is working only for subfields of 995 field mapped with specific indexes, and also in index (ex : $a, $b...) It is not working for the other subfields (ex : $g), because a comment from record.abs was integrated in DOM config files. This patch removes the comment. To test, in a DOM UNIMARC environment : 1) in a item, write some value "Test10037" in 995$g 2) search for this value in simple search, this way : item=Test10037 => you should have no results 3) apply the patch. if necessary, copy the modified src/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml and src/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl into the /etc/... directory in your main Koha directory 4) reindex zebra biblios 5) do the same search as 2) => you should have one result M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17495|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21061&action=edit [SIGNED-OF] Bug 10037 : item index is broken in UNIMARC DOM indexing In UNIMARC DOM indexing, "item" index is working only for subfields of 995 field mapped with specific indexes, and also in index (ex : $a, $b...) It is not working for the other subfields (ex : $g), because a comment from record.abs was integrated in DOM config files. This patch removes the comment. To test, in a DOM UNIMARC environment : 1) in a item, write some value "Test10037" in 995$g 2) search for this value in simple search, this way : item=Test10037 => you should have no results 3) apply the patch. if necessary, copy the modified src/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml and src/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl into the /etc/... directory in your main Koha directory 4) reindex zebra biblios 5) do the same search as 2) => you should have one result Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Test NOTE: default UNIMARC framework don't have 995g, so I must add it first. 1) Added test string to 995b on some record 2) Reindex and search as indicated, no results 3) cp files to destination 4) reindex 5) search and result ok ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bit stuck on testing here as I have some errors on running a full reindex: REINDEXING zebra ==================== 00:34:32-07/10 zebraidx(27269) [warn] isamb: Inconsistent register (2) zebraidx: isamb.c:1102: insert_leaf: Assertion `*lookahead_mode' failed. 00:34:33-07/10 zebraidx(27279) [warn] previous transaction didn't reach commit I will have to investigate some more. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello That's maybe related with other errors in the config file. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- By the way it is probably not a good thing to index all subfields of 995 in the same item index, because some subfields contains data useless to index (as internal notes...). But it could be the object of an other patch after this one is pushed. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m Severity|minor |normal --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The patch works as expected and the behavior is consistent to me. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21061|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21940&action=edit Bug 10037 : item index is broken in UNIMARC DOM indexing In UNIMARC DOM indexing, "item" index is working only for subfields of 995 field mapped with specific indexes, and also in index (ex : $a, $b...) It is not working for the other subfields (ex : $g), because a comment from record.abs was integrated in DOM config files. This patch removes the comment. To test, in a DOM UNIMARC environment : 1) in a item, write some value "Test10037" in 995$g 2) search for this value in simple search, this way : item=Test10037 => you should have no results 3) apply the patch. if necessary, copy the modified src/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml and src/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl into the /etc/... directory in your main Koha directory 4) reindex zebra biblios 5) do the same search as 2) => you should have one result Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Test NOTE: default UNIMARC framework don't have 995g, so I must add it first. 1) Added test string to 995b on some record 2) Reindex and search as indicated, no results 3) cp files to destination 4) reindex 5) search and result ok ! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #3)
Bit stuck on testing here as I have some errors on running a full reindex: REINDEXING zebra ==================== 00:34:32-07/10 zebraidx(27269) [warn] isamb: Inconsistent register (2) zebraidx: isamb.c:1102: insert_leaf: Assertion `*lookahead_mode' failed. 00:34:33-07/10 zebraidx(27279) [warn] previous transaction didn't reach commit
I will have to investigate some more.
Note: I hadn't these errors on reindexing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's very likely my Zebra UNIMARC configuration was problematic, as I had tested other patches before. Thx Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 --- Comment #10 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Anyway, the current code was obviously wrong ;-) "<target_index>item # just to index every subfield:w</target_index>" Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master along with a regression test. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org