[Bug 20067] New: Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Bug ID: 20067 Summary: Authorised values for ORDER_CANCELLATION_REASON are displayed on notice (catalogue/detail.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@collecto.ca QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 70807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70807&action=edit notice view Hi, Is it normal contents of authorised values of the ORDER_CANCELLATION category are displayed in items table for the materials specified fields? Test plan: 1. Fill with 2 in a subfield 952 $3 and save item 2. Display item table in normal view 3. See column Materials specified which display authorised values instead of number 2 See attached images Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- Created attachment 70808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70808&action=edit item table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- Created attachment 70809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70809&action=edit authorized values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marjorie, can you check in your framework for 952$3 which authorised value it's mapped to? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #4 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Katrin Fischer from comment #3)
Hi Marjorie, can you check in your framework for 952$3 which authorised value it's mapped to?
Hi Katrin, There is no mapped authorised value to the 952 $ 3 field. have you been able to reproduce the problem of your board? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marjorie, are you sure? Your screenshots shows numeric values for materials, that's why I was asking. Do you enter them manually? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #6 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Katrin Fischer from comment #5)
Hi Marjorie, are you sure? Your screenshots shows numeric values for materials, that's why I was asking. Do you enter them manually?
Oh yes, i entered them manually. If i write "vol.1", it's correct but if I write only the numbers it displays the text of the authorized value of ORDER_CANCELLATION_REASON Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Last question: Which version exactly? I will try to test :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #8 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Katrin Fischer from comment #7)
Last question: Which version exactly? I will try to test :)
Tested on 16.11.00 and 17.05.05. Thanks! Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marjorie, can confirm this with the sample data on master! To test: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the error is in detail.pl around here: $mss = Koha::MarcSubfieldStructures->search({ frameworkcode => $fw, kohafield => 'items.materials', authorised_value => { not => undef } }); my %materials_map; use Data::Dumper; warn Dumper $mss->count; if ($mss->count) { my $materials_authvals = GetAuthorisedValues($mss->next->authorised_value); if ($materials_authvals) { foreach my $value (@$materials_authvals) { $materials_map{$value->{authorised_value}} = $value->{lib}; } } } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |17250 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757 Bug 17250: Do not retrieve marc subfield structure when the authorised value is not defined Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250 [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #11)
Caused by commit 0b6f129ac32e5ea3a2d1357d8e19ba3e24519757 Bug 17250: Do not retrieve marc subfield structure when the authorised value is not defined
Or maybe before... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What we need is: select authorised_value from marc_subfield_structure where frameworkcode = "BKS" and kohafield = "items.materials" and authorised_value is not null and authorised_value != ""; But I am failing to translate this correctly at the moment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72100&action=edit Bug 20067: Fix false display of authorised value for materials on staff detail page Koha didn't check for a linked authorised value category for items.materials correctly which led to displaying false information on the detail page. To test: - before applying the patch: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' - apply patch - check display, it should now show "2" - link 952$3 (MARC21) to ORDER_CANCELLATION_REASON - check display again, it should now show 'restocking' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72101&action=edit Bug 20067: Fix other checks for linked authorised value categories The same pattern was used in other files, this patch fixes it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After getting some sleep... :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- you defined twice the same key "!=" in the condition hashref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Koha::MarcSubfieldStructures->search( { frameworkcode => '', kohafield => 'items.materials', -or => [ { authorised_value => { not => undef } }, { authorised_value => { '!=' => '' } } ] } ); will generate SELECT `me`.`tagfield`, `me`.`tagsubfield`, `me`.`liblibrarian`, `me`.`libopac`, `me`.`repeatable`, `me`.`mandatory`, `me`.`kohafield`, `me`.`tab`, `me`.`authorised_value`, `me`.`authtypecode`, `me`.`value_builder`, `me`.`isurl`, `me`.`hidden`, `me`.`frameworkcode`, `me`.`seealso`, `me`.`link`, `me`.`defaultvalue`, `me`.`maxlength` FROM `marc_subfield_structure` `me` WHERE ( ( ( `authorised_value` IS NOT NULL OR `authorised_value` != ? ) AND `frameworkcode` = ? AND `kohafield` = ? ) ): '', '', 'items.materials' Which is what we want. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72100|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72120&action=edit Bug 20067: Fix false display of authorised value for materials on staff detail page Koha didn't check for a linked authorised value category for Koha didn't check for a linked authorised value category for items.materials correctly which led to displaying false information on the detail page. To test: - before applying the patch: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' - apply patch - check display, it should now show "2" - link 952$3 (MARC21) to ORDER_CANCELLATION_REASON - check display again, it should now show 'restocking' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72101|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72121&action=edit Bug 20067: Fix other checks for linked authorised value categories The same pattern was used in other files, this patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #21 from delaye <stephane.delaye@biblibre.com> --- the tile of the ticket is not good. it is rather 'Display the description authorised valeur is you mapping with items.materials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72120|0 |1 is obsolete| | --- Comment #22 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 72991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72991&action=edit Bug 20067: Fix false display of authorised value for materials on staff detail page Koha didn't check for a linked authorised value category for Koha didn't check for a linked authorised value category for items.materials correctly which led to displaying false information on the detail page. To test: - before applying the patch: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' - apply patch - check display, it should now show "2" - link 952$3 (MARC21) to ORDER_CANCELLATION_REASON - check display again, it should now show 'restocking' Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72121|0 |1 is obsolete| | --- Comment #23 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 72992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72992&action=edit Bug 20067: Fix other checks for linked authorised value categories The same pattern was used in other files, this patch fixes it. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authorised values for |Wong display of authorised |ORDER_CANCELLATION_REASON |value for items.materials |are displayed on notice |on staff detail page |(catalogue/detail.pl) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@joensuu.fi Summary|Wong display of authorised |Wrong display of authorised |value for items.materials |value for items.materials |on staff detail page |on staff detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72991|0 |1 is obsolete| | Attachment #72992|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73181&action=edit Bug 20067: Fix false display of authorised value for materials on staff detail page Koha didn't check for a linked authorised value category for Koha didn't check for a linked authorised value category for items.materials correctly which led to displaying false information on the detail page. To test: - before applying the patch: - make sure sample data and configuration is loaded - edit any item - write 2 in the $3 materials specificed - check the details page normal view - it will display 'restocking' - apply patch - check display, it should now show "2" - link 952$3 (MARC21) to ORDER_CANCELLATION_REASON - check display again, it should now show 'restocking' Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73182&action=edit Bug 20067: Fix other checks for linked authorised value categories The same pattern was used in other files, this patch fixes it. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, backported to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #28 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Conflict for 17.05.x in circ/circulation.pl. I will not risk to release in 17.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20067 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org