[Bug 27445] New: OPAC header tweaks for non-JavaScript users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Bug ID: 27445 Summary: OPAC header tweaks for non-JavaScript users Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If you're using the OPAC with JavaScript disabled, the "Cart" link should not appear. The lists and user/login link should be styled as links since they don't trigger menus when JS is off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115212&action=edit Bug 27445: OPAC header tweaks for non-JavaScript users This patch makes some minor changes to the header menu in the OPAC visible only to users with JavaScript support. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - View the OPAC with JS disabled in your browser. - The "Cart" button should not be visible. - The "List," "Log in," and "Search history" links should be styled blue like other links. - Log in to the OPAC and confirm that the "Welcome <name>" link is also styled like other links. - Enable JavaScript and verify that the links appear and function just as they did before the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115212|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 120848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120848&action=edit Bug 27445: OPAC header tweaks for non-JavaScript users This patch makes some minor changes to the header menu in the OPAC visible only to users with JavaScript support. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - View the OPAC with JS disabled in your browser. - The "Cart" button should not be visible. - The "List," "Log in," and "Search history" links should be styled blue like other links. - Log in to the OPAC and confirm that the "Welcome <name>" link is also styled like other links. - Enable JavaScript and verify that the links appear and function just as they did before the patch. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28662 [Bug 28662] Not possible to log out of patron account in OPAC with JavaScript disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this is a clear improvement to "without the patch", but I was not able to log out without JavaScript, so have filed a new bug report: bug 28662 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120848|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 122579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122579&action=edit Bug 27445: OPAC header tweaks for non-JavaScript users This patch makes some minor changes to the header menu in the OPAC visible only to users with JavaScript support. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - View the OPAC with JS disabled in your browser. - The "Cart" button should not be visible. - The "List," "Log in," and "Search history" links should be styled blue like other links. - Log in to the OPAC and confirm that the "Welcome <name>" link is also styled like other links. - Enable JavaScript and verify that the links appear and function just as they did before the patch. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27445 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Not pushed for 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org