[Bug 3671] New: XSLT results list display problem if no fixed fields
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 Summary: XSLT results list display problem if no fixed fields Product: Koha Version: rel_3_0 Platform: PC OS/Version: Windows 2000 Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: jmf@liblime.com ReportedBy: jwagner@ptfs.com Estimated Hours: 0.0 Change sponsored?: --- Created an attachment (id=1177) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1177) Screenshot of record with font problem Loading a very brief record (no proper fixed fields) like this =LDR 00474 2200157 4500 =008 $a 362 =022 \\$a0190-8286 =090 \\$aNewspaper =245 \\$aThe Washington post =246 \\$aWashington post (Washington, D.C. : $b 1974) =260 \\$aWashington, D.C. : $b The Washington Post Co., $c 1974- =300 \\$av. : $b ill.; $c 61 cm. =310 \\$aDaily =590 \\$aLibrary retains 2 weeks' back issues. the OPAC XSLT results list has a some kind of a font or label problem. All of the lines after the point where the XSLT icons for material type etc. would display are in a much smaller font than normal for other titles. If I create even the briefest 007 for this record (ta in first two positions), the display goes back to normal. So I think there must be a mis-matched span or something around the section in MARC21slim2OPACResults.xsl that looks for and displays the type icons, but I haven't been able to spot it. Can anyone else see the problem? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 --- Comment #1 from Jane Wagner <jwagner@ptfs.com> 2009-09-26 16:27:07 --- Created an attachment (id=1178) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1178) Screenshot where adding an 007 fixed the font -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 --- Comment #2 from Jane Wagner <jwagner@ptfs.com> 2009-09-26 16:29:44 --- I did try adding some of the other fields that aren't displaying, like author and 250, and their fonts are normal. The problem seems to be centered around the line that displays the icons. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Jane Wagner <jwagner@ptfs.com> 2009-10-07 13:44:06 --- I did a line-by-line readthrough of that section of code, and couldn't find any mis-matched statements. Then I did some experimenting with removing various statements, and found that the problem seems to be the opening/closing <span class="results_summary"> (all the intervening code) </span> -- if I take out the span class statement (and its /span), the fonts display normally. As an experiment, I tried adding a blank space to the very end of the section: <xsl:when test="$controlField008-22='f'"> Specialized; </xsl:when> </xsl:choose> </xsl:if> <xsl:text> </xsl:text> </span> </xsl:if> Adding the <xsl:text> </xsl:text> cures the font problem -- if there is no 007 at all in the record, the subsequent text is in normal font. I don't know why adding this blank space fixes the problem, but I'm going to submit a patch with it, so that incomplete records don't suffer the display problem. I know the ideal solution is to clean the record up, but that may take a while for this collection. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 --- Comment #4 from Jane Wagner <jwagner@ptfs.com> 2009-10-07 13:44:49 --- Created an attachment (id=1203) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1203) Screenshot where adding blank space in XSLT fixed font problem -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #5 from Jane Wagner <jwagner@ptfs.com> 2009-10-07 13:55:40 --- Patch sent October 7, 2009. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> 2010-05-10 20:42:20 --- Patch pushed to HEAD. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #7 from Jane Wagner <jwagner@ptfs.com> 2010-05-10 21:00:02 --- Seems to be fixed in the latest head OPAC. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3671 --- Comment #8 from Jane Wagner <jwagner@ptfs.com> 2010-05-12 13:42:32 --- Fix also available (in ptfs-harley) at http://github.com/Koha-PTFS, branch Bug3671 -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com