[Bug 24959] New: Fix id/label pairs in saved reports table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Bug ID: 24959 Summary: Fix id/label pairs in saved reports table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 24886 In the table of saved reports the number in the 'ID' column is wrapped in a <label> tag, but clicking it doesn't check the corresponding checkbox because the "for" attribute doesn't match the ID of the checkbox. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 [Bug 24886] Reindent reports template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 101495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101495&action=edit Bug 24959: Fix id/label pairs in saved reports table This patch adds a unique id attribute to each checkbox in the table of saved reports. Also updated is the corresponding <label>'s "for" attribute so that clicking the report id will toggle the checkbox. To reproduce, go to Reports -> Use saved and click a number in the ID column. Nothing happens. After applying the patch clicking the number should check or uncheck the corresponding checkbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101495|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 101538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101538&action=edit Bug 24959: Fix id/label pairs in saved reports table This patch adds a unique id attribute to each checkbox in the table of saved reports. Also updated is the corresponding <label>'s "for" attribute so that clicking the report id will toggle the checkbox. To reproduce, go to Reports -> Use saved and click a number in the ID column. Nothing happens. After applying the patch clicking the number should check or uncheck the corresponding checkbox. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 101540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101540&action=edit Bug 24541: Purge old messages misc/cronjobs/cleanup_database.pl provides some database cleanup. This patch adds cleanup for messages table. Test plan : - Count messages : select count(*),date(message_date) from messages group by date(message_date); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --messages 365 - Recount messages Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101540|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Comment on attachment 101540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101540 Bug 24541: Purge old messages Sorry, wrong bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101538|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101767&action=edit Bug 24959: Fix id/label pairs in saved reports table This patch adds a unique id attribute to each checkbox in the table of saved reports. Also updated is the corresponding <label>'s "for" attribute so that clicking the report id will toggle the checkbox. To reproduce, go to Reports -> Use saved and click a number in the ID column. Nothing happens. After applying the patch clicking the number should check or uncheck the corresponding checkbox. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok, no errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24959 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- not backported due to dependencies -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org