https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 81340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81340&action=edit Bug 21698 - FIX POD of cancel_unfilled_holds.pl To test: - Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl" - Notice some problems: -- No description in the NAME section -- Descriptions of options in the SYNOPSIS section -- A literal head1 -- Long options are listed with a single leading dash -- Options --verbose and --confirm are not listed under OPTIONS) - Take a look at the script itself to see that --verbose and --confirm should be listed. - Also note the typo on line 97: 'v|verbosev' => \$verbose, - Apply the patch - Look at the script and perldoc again and check that all problems described above are now fixed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81340|0 |1 is obsolete| | --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 81499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81499&action=edit Bug 21698 - FIX POD of cancel_unfilled_holds.pl To test: - Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl" - Notice some problems: -- No description in the NAME section -- Descriptions of options in the SYNOPSIS section -- A literal head1 -- Long options are listed with a single leading dash -- Options --verbose and --confirm are not listed under OPTIONS) - Take a look at the script itself to see that --verbose and --confirm should be listed. - Also note the typo on line 97: 'v|verbosev' => \$verbose, - Apply the patch - Look at the script and perldoc again and check that all problems described above are now fixed. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81499|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81534&action=edit Bug 21698: Fix POD of cancel_unfilled_holds.pl To test: - Run "perldoc misc/cronjobs/holds/cancel_unfilled_holds.pl" - Notice some problems: -- No description in the NAME section -- Descriptions of options in the SYNOPSIS section -- A literal head1 -- Long options are listed with a single leading dash -- Options --verbose and --confirm are not listed under OPTIONS) - Take a look at the script itself to see that --verbose and --confirm should be listed. - Also note the typo on line 97: 'v|verbosev' => \$verbose, - Apply the patch - Look at the script and perldoc again and check that all problems described above are now fixed. Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.06 - I always like POD improvements. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21698 --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- 18720 -- You are receiving this mail because: You are watching all bug changes.