[Bug 16112] New: Specify due date for batch renew
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Bug ID: 16112 Summary: Specify due date for batch renew Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@ccsr.qc.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hi, Currently , we can not manually select a renewal due date in the batch renewal tool (renew.pl). This could be a system preference like specifyDueDate or SpecifyReturnDate. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16748 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107786&action=edit Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107786|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 107835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107835&action=edit Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bolshawh@parliament.uk --- Comment #4 from Henry Bolshaw <bolshawh@parliament.uk> --- I was able to follow the test plan and select a renewal date for batch renew. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107835|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107865&action=edit Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry Henry, I had to redo the patch. I embedded a patch of this development on bug 16748 (as you noticed). As I modified the patch I need to ask for another signoff. Please retest it if you have some time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107865|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107890&action=edit Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107891&action=edit Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #9 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108639&action=edit Bug 24288: Add wording to authorized value interface to indicate valid code length Chnged NOTFORLOAN to NOT_LOAN This patch adds a warning that the authorized value field needs to be a single numeric character, where appropriate To test: 1) Apply the patch 2) Add a new authorised value policy in the LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN categories 3) Check that there is a new warning displaying next to the Authorized value field stating "The authorized value field in the X category must be a one-digit numeric value" 4) Check that this same warning appears when modifying the same authorised values 5) Check that the warning doesn't appear in any other authorized value category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #10 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108640&action=edit Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108640|0 |1 is obsolete| | --- Comment #11 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108641&action=edit Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107891|0 |1 is obsolete| | --- Comment #12 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108658&action=edit Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108658|0 |1 is obsolete| | --- Comment #13 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108659&action=edit Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108641|0 |1 is obsolete| | --- Comment #14 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108661&action=edit Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108661|0 |1 is obsolete| | --- Comment #15 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108662&action=edit Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108662|0 |1 is obsolete| | --- Comment #16 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108663&action=edit Bug 16371: (follow-up) DB changes We need to keep "opac" is the pref was set before the upgrade Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108659|0 |1 is obsolete| | --- Comment #17 from Marco Abi-Ramia <marco.abi-ramia@inlibro.com> --- Created attachment 108665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108665&action=edit Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Marco Abi-Ramia <marco.abi-ramia@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marco.abi-ramia@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108639|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108663|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is close, but not quite right: Instead of modeling the 'specify due date' feature, this should model the "renewal due date" feature we have in circulation (footer of the circulation table). So we should change the labelling and also the 'activation' conditions. The renewal due date option is always visible and doesn't depend on the SpecifyDueDate preference. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Specify due date for batch |Specify renewal date for |renew |batch renew -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108776&action=edit Bug 16112: Do not depend on SpecifyDueDate It's possible to specify a renewal due date in the checkouts table even if SpecifyDueDate is off. Also change the label from "Specify due date:" to "Renewal due date:" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107890|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108871&action=edit Bug 16112: Add the ability to define due date for batch renew Same as bug 16748, for batch renew. Test plan: Check an item in Renew it using the circ/renew.pl page => You can pick a due date! => The date is kept from one renew to another Renew it until you reach the maximum number of renewals => You get a warning with "continue without renewing" => The date is still kept Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108665|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108872&action=edit Bug 16112: (follow-up) Form style improvements, clear date This follow-up makes some markup and style improvements in order to make the renew form more consistent with similar forms like checkout and check-in. It also adds a "Clear" button for the datepicker field, matching similar date inputs. To test, apply the patch and go to Circulation -> Renew. - With or without the SpecifyDueDate system preference enabled the form should look correct. - With the SpecifyDueDate preference enabled you should see the date form below the barcode input field. - Select a date and test that the "Clear" button works to clear it. - Compare to the check-in page to confirm that they look consistent with each other. Signed-off-by: Marco Abi-Ramia <marco.abi-ramia@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108776|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 108873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108873&action=edit Bug 16112: Do not depend on SpecifyDueDate It's possible to specify a renewal due date in the checkouts table even if SpecifyDueDate is off. Also change the label from "Specify due date:" to "Renewal due date:" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |Add the ability to define release notes| |the due date during a batch | |renew. | |Like bug 16748 for | |batch checkout. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org