[Bug 42606] New: Error when importing a record using Z39.50 from the cataloging home page
From the cataloging home page, click "New from Z39.50" without choosing a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Bug ID: 42606 Summary: Error when importing a record using Z39.50 from the cataloging home page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, angela.berrett@familysearch.org, blawlor@clamsnet.org, bugzilla@koha-us.org, carthur@slolibrary.org, cbrannon@cdalibrary.org, david@davidnind.com, dcook@prosentient.com.au, echandler@clamsnet.org, george@nekls.org, jonathan.druart@gmail.com, lauren_denny@sil.org, lisette@bywatersolutions.com, lucas@bywatersolutions.com, m.de.rooy@rijksmuseum.nl, mike.grgurev@mainlib.org, mnero@oslri.net, mspinney@clamsnet.org, nmumford@clamsnet.org Depends on: 32773 framework in the dropdown menu. Perform a Z39.50 search in the popup window, then click "Import" for one of the results. This triggers an error in the parent window: Can't call method "is_fast_add" on an undefined value at /kohadevbox/koha/cataloguing/addbiblio.pl line 518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 [Bug 32773] Have the ability to have more than 1 Fast Add framework -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 199143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199143&action=edit Bug 42606: Check for default framework earlier The code switches 'Default' to '' - we should just do it immediately after fetching from the template 1 - From the cataloging home page, click "New from Z39.50" without choosing a framework in the dropdown menu. 2 - Perform a Z39.50 search in the popup window, then click "Import" for one of the results. This triggers an error in the parent window: 3 - Error:Can't call method "is_fast_add" on an undefined value at /kohadevbox/koha/cataloguing/addbiblio.pl line 518 4 - Apply patch 5 - Reload and repeat 6 - Success! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199143|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 199144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199144&action=edit Bug 42606: Check for default framework earlier The code switches 'Default' to '' - we should just do it immediately after fetching from the template 1 - From the cataloging home page, click "New from Z39.50" without choosing a framework in the dropdown menu. 2 - Perform a Z39.50 search in the popup window, then click "Import" for one of the results. This triggers an error in the parent window: 3 - Error:Can't call method "is_fast_add" on an undefined value at /kohadevbox/koha/cataloguing/addbiblio.pl line 518 4 - Apply patch 5 - Reload and repeat 6 - Success! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |bibliothek@th-wildau.de --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- This would reintroduce https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39544 and show warnings like ==> /var/log/koha/kohadev/plack-intranet-error.log <== [2026/05/19 08:28:56] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 500. when calling http://main-intra.localhost/cgi-bin/koha/cataloguing/addbiblio.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199286&action=edit Bug 42606: Prevent warning And reintroducing bug 39544. But what we are doing here is fragile, we should definitely improve this $frameworkcode code and make it more robust and easy to read. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- I've not tested, only tried to fix Jan's concern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 199288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199288&action=edit Bug 42606: (follow-up) Remove second check Removes another check for if frameworkcode is defined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199286|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 199464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199464&action=edit Bug 42606: Check for default framework earlier The code switches 'Default' to '' - we should just do it immediately after fetching from the template 1 - From the cataloging home page, click "New from Z39.50" without choosing a framework in the dropdown menu. 2 - Perform a Z39.50 search in the popup window, then click "Import" for one of the results. This triggers an error in the parent window: 3 - Error:Can't call method "is_fast_add" on an undefined value at /kohadevbox/koha/cataloguing/addbiblio.pl line 518 4 - Apply patch 5 - Reload and repeat 6 - Success! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #8 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 199465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199465&action=edit Bug 42606: (QA follow-up): Fix order of checking for frameworkcode This adds more verbosity to the check for frameworkcode and changes the order of setting a default value '' for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- I changed the order for checking for frameworkcode again and added a bit of explanation for the new order in the comments. If you are okay with that I would set it as passed QA to get it off the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199526&action=edit Bug 42606: Check for default framework earlier The code switches 'Default' to '' - we should just do it immediately after fetching from the template 1 - From the cataloging home page, click "New from Z39.50" without choosing a framework in the dropdown menu. 2 - Perform a Z39.50 search in the popup window, then click "Import" for one of the results. This triggers an error in the parent window: 3 - Error:Can't call method "is_fast_add" on an undefined value at /kohadevbox/koha/cataloguing/addbiblio.pl line 518 4 - Apply patch 5 - Reload and repeat 6 - Success! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199527&action=edit Bug 42606: (QA follow-up): Fix order of checking for frameworkcode This adds more verbosity to the check for frameworkcode and changes the order of setting a default value '' for it. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199528&action=edit Bug 42606: Add Cypress tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|bibliothek@th-wildau.de |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate | Text to go in the| |26.05.00 release notes| | Status|Passed QA |Pushed to main --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed to 26.05.x for 26.05.00. Good work all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|26.05.00 | release notes| | CC| |phil@chetcolibrary.org Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Bug introduced in 26.05, not backporting to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org