http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11498&action=edit Proposed patch Main problem is that in opac-results.tt, the hidden items are managed in available items loop, but they are in others loop. Second problem is that adding hidden items in other items list will give false lost/damaged/withdrawn/onloan/onhold/... count number. Since these items are not displayed, there is no need to send them to template. So i changed behavior : if item is hidden it is not in item loops. Test plan : ----------- Check display with 'OpacHiddenItems' syspref hidding some items and all items. Check display with 'hidelostitems' syspref hidding some lost items and all items. Combine with and without XSLT. Test with bug 6488 tests : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6488#c45 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #2)

Is this still a problem?I can't reproduce it and also if we're going to remove hidelostitems (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619) do we need this patch?

Yes it is still a problem, this bug concerns hidelostitems but also OpacHiddenItems behavior. I forgot : to reproduce the but, hidden items must be unavailable (on loan, damaged, not for loan ...). Tell me if you need a better test plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 --- Comment #5 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- On my test environment (master revision and sandbox 2 database), I reproduce the bug. hilelostitems is active. With 1 item available and 1 lost (itemlost=1), I get : Availability: Copies available: Le Cannet (1), Lost (1). Result page gets items from Zebra so after editing an item, don't forget to rebuild. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)

Created attachment 11878 [details] [SIGNED-OFF] Bug 7690: hidelostitems not working in Normal Display Signed-off-by: Owen Leonard <oleonard@myacpl.org>

patch looks good, passing QA… $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * f14ca82 Bug 7690: hidelostitems not working in Normal Display C4/Search.pm koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt * C4/Search.pm OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Template change, but no string changes, pushing to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.