[Bug 26151] New: Remove the use of jquery.checkboxes plugin from suggestions management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Bug ID: 26151 Summary: Remove the use of jquery.checkboxes plugin from suggestions management page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 26006 As described in Bug 26006 the jquery.checkboxes plugin is old and unmaintained. Its use should be replaced on the suggestions management page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26006 [Bug 26006] OMNIBUS: Remove the use of jquery.checkboxes plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 107854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107854&action=edit Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Brandon J <brandon.jimenez@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Brandon J <brandon.jimenez@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107854|0 |1 is obsolete| | --- Comment #2 from Brandon J <brandon.jimenez@inlibro.com> --- Created attachment 110112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110112&action=edit Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110112|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110125&action=edit Bug 26151: Remove the use of jquery.checkboxes plugin from suggestions management page This patch removes the use of the jquery.checkboxes plugin from the suggestions management page and replaces it with custom JS. To test, apply the patch and go to Acquisitions -> Suggestions Under each tab ("Accepted," "Pending," etc.), test that the "Check all" and "Uncheck all" controls work correctly and only affect the table on that tab. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26151 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org