[Bug 6958] New: Missing spaces in translated templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Bug #: 6958 Summary: Missing spaces in translated templates Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: I18N/L10N AssignedTo: frederic@tamil.fr ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org I noticed that especially in breadcrubs and texts that contains links and normal text spaces are missing from the po file and so from the translated templates. Examples: 1) Breadcrumbs on patron module start page: English: Start > Patrons German: Start> Benutzer The po file for the first part of the breadcrumbs looks like this: [...] #: intranet-tmpl/prog/en/modules/errors/405.tt:10 #, c-format msgid "Home" msgstr "Start" When changing "Start" to "Start " the templates look correct. This is only an example, the spaces before the > are missing in general on all breadcrumbs. 2) Fines on patron account (check out tab) English: Fines: Patron has Outstanding fines of 1.00. Make Payment German: Gebühren:Benutzer hat offene Gebühren in Höhe von 1.00. Zahlung The space after Fines: is missing. The po fiole looks like this: #: intranet-tmpl/prog/en/modules/circ/circulation.tt:574 #, c-format msgid "Fines:" msgstr "Gebühren:" #: intranet-tmpl/prog/en/modules/circ/circulation.tt:569 #: intranet-tmpl/prog/en/modules/circ/circulation.tt:574 #, c-format msgid "Patron has " msgstr "Benutzer hat " There are lot of other examples. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-03 20:39:40 UTC --- Hmm it looks like its the replacement when putting the .po file back into the templates that is the problem. Investigating more -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-03 21:12:17 UTC --- Right here the problem </a> › Error 405</div> Becomes </a>› Fehler 405</div> Tracking down why now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> 2011-10-04 07:29:31 UTC ---
Tracking down why now
I've tried without success. It seems that stings containing › are parsed as a TEXT_PARAMATRIZED tokens, which is false. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-04 07:32:54 UTC --- I have a patch which adds the space back in. Katrin is testing it more, to make sure it has no unintended side effects. Its not a very elegant solution but seems to work. Ill attach it to the bug once Katrin has a little more time to test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-04 20:37:49 UTC --- Created attachment 5707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5707 Bug 6958 : Fix for leading spaces being stripped on translation This will re-add any leading spaces, so formatting is not messed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-04 20:38:43 UTC --- Please test a lot, it is pretty harmless only adds whitespace if needed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5707|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-05 05:59:14 UTC --- Created attachment 5712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5712 screenshot Tested on 5.4.x with complete German po files. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5712|screenshot |[SIGNED-OFF] Bug 6958 : Fix description| |for leading spaces being | |stripped on translation -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-06 13:46:20 UTC --- The logic in this patch looks sound; the same basic functionality is preserved, with an expansion in the event that the string starts with leading spaces, which are now preserved. Logic is actually now much more readable, so improvement there. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-06 20:47:56 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6958 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |paul.poulain@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org