[Bug 39489] New: 'Refine your search' should have an aria-expanded attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Bug ID: 39489 Summary: 'Refine your search' should have an aria-expanded attribute Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: chloe.zermatten@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org So that screen reader users aren't misled into thinking that the 'Refine Search' section header will take them to another page, add an aria-expanded attribute, and set its value to true if the section is expanded, and false if it is not. This will clearly mark 'Refine Search' as a collapsible section. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chloe.zermatten@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 --- Comment #1 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 180300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180300&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon the section being expanded. To test: 1) Apply the patch. 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180300|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180705&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon the section being expanded. To test: 1) Apply the patch. 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- 1) If I load the page on a large screen, the facets are shown but aria-expanded attribute is "false". Shouldn't it be "true" ? or even removed (since it's not collapsible) ? 2) setAriaExpandable toggles the attribute value for all .menu-collapse-toggle on the page no matter which one is clicked. This isn't a real issue currently as there is only one .menu-collapse-toggle per page, but it could become an issue if other similar sections are introduced, and it can be easily fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 --- Comment #4 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- (In reply to Julian Maurice from comment #3)
1) If I load the page on a large screen, the facets are shown but aria-expanded attribute is "false". Shouldn't it be "true" ? or even removed (since it's not collapsible) ?
2) setAriaExpandable toggles the attribute value for all .menu-collapse-toggle on the page no matter which one is clicked. This isn't a real issue currently as there is only one .menu-collapse-toggle per page, but it could become an issue if other similar sections are introduced, and it can be easily fixed.
Thank you for the feedback! Agreed on both counts, will update the patch to account for both. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180705|0 |1 is obsolete| | --- Comment #5 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 181372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181372&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181372|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 181568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181568&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the "Refine your release notes| |search" section in the | |OPAC. For screen reader | |users on smaller screens, | |it now correctly announces | |that it is an expandable | |section, instead of a link | |(by adding an aria-expanded | |attribute). | | | |Explanation: | |The 'Refine your search' | |expandable section in the | |Koha OPAC was not clearly | |announced by screen readers | |for smaller screen sizes. | |This is because the | |expandable section was | |identified and announced as | |a link. This resulted in | |screen reader users | |incorrectly expecting a | |link to another page, and | |not being informed that it | |was an expandable section. --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To display the "Most popular" link under the search box, set the OpacTopissue system preference to "Allow". 2. To see the full history for a subscription: 2.1 Set the SubscriptionHistory system preference to "full history". 2.2 Set up a serial using the serials module (no need to add any items). 2.3 View the record in the OPAC 2.4 Select the Subscriptions tab. 2.5 Click the "More details" link under the latest issues table. 2.6 You should now be on the full subscription history page for the serial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Not my expertise area but IMO we should not see screen size in JS: + if (window.screen.width > 991) { + $(".menu-collapse-toggle").removeAttr("aria-expanded"); + } Cannot we avoid that? Do we want the attribute to be adjusted if the window is resized? Could we have aria-expanded adjusted depending on the arrow visibility? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181568|0 |1 is obsolete| | --- Comment #9 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 182489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182489&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. 16) Resize your viewport below 992px, and notice that 'aria-expanded' reappears and is set to false. 17) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to false. 18) Open 'Refine your search', notice that 'aria-expanded' is set to true. 19) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to true. Note: now updated to handle screen resizes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #8)
Not my expertise area but IMO we should not see screen size in JS:
+ if (window.screen.width > 991) { + $(".menu-collapse-toggle").removeAttr("aria-expanded"); + }
Cannot we avoid that?
Do we want the attribute to be adjusted if the window is resized?
Could we have aria-expanded adjusted depending on the arrow visibility?
Thank you for the feedback! I had a go at implementing this, hopefully it addresses the points you raised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182489|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 182565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182565&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. 16) Resize your viewport below 992px, and notice that 'aria-expanded' reappears and is set to false. 17) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to false. 18) Open 'Refine your search', notice that 'aria-expanded' is set to true. 19) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to true. Note: now updated to handle screen resizes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Comment on attachment 182565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182565 Bug 39489: 'Refine your search' aria-expanded attribute Review of attachment 182565: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=39489&attachment=182565) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/js/results-list.js @@ +240,4 @@
KOHA.Tags.add_tag_button(thisid, tag); return false; }); + $(window).on("resize load", function () {
This is not needed: there is already a function (facetMenu) called on load and whenever the screen width goes under or above the break point of 992px (and only in that case, not on every resize) You should put the aria-expanded logic in facetMenu @@ +244,5 @@
+ $(".menu-collapse-toggle").each(function () { + const beforeContent = window.getComputedStyle( + this, + "::before" + ).content;
You should avoid relying on style to define behavior, because whenever the style change it might break functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182565|0 |1 is obsolete| | --- Comment #13 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 182735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182735&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. 16) Resize your viewport below 992px, and notice that 'aria-expanded' reappears and is set to false. 17) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to false. 18) Open 'Refine your search', notice that 'aria-expanded' is set to true. 19) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to true. Note: now updated to handle screen resizes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- (In reply to Julian Maurice from comment #12)
Comment on attachment 182565 [details] [review] Bug 39489: 'Refine your search' aria-expanded attribute
Review of attachment 182565 [details] [review]: -----------------------------------------------------------------
::: koha-tmpl/opac-tmpl/bootstrap/js/results-list.js @@ +240,4 @@
KOHA.Tags.add_tag_button(thisid, tag); return false; }); + $(window).on("resize load", function () {
This is not needed: there is already a function (facetMenu) called on load and whenever the screen width goes under or above the break point of 992px (and only in that case, not on every resize) You should put the aria-expanded logic in facetMenu
@@ +244,5 @@
+ $(".menu-collapse-toggle").each(function () { + const beforeContent = window.getComputedStyle( + this, + "::before" + ).content;
You should avoid relying on style to define behavior, because whenever the style change it might break functionality.
Thank you for the pointers - patch amended accordingly! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from David Nind <david@davidnind.com> --- Changed to signed off, ready for QA again. (I don't think it needs to be tested again, as this is just incorporating QA feedback.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please add a signoff line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182735|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 183057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183057&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. 16) Resize your viewport below 992px, and notice that 'aria-expanded' reappears and is set to false. 17) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to false. 18) Open 'Refine your search', notice that 'aria-expanded' is set to true. 19) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to true. Note: now updated to handle screen resizes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183057|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183825&action=edit Bug 39489: 'Refine your search' aria-expanded attribute On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. 16) Resize your viewport below 992px, and notice that 'aria-expanded' reappears and is set to false. 17) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to false. 18) Open 'Refine your search', notice that 'aria-expanded' is set to true. 19) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to true. Note: now updated to handle screen resizes Sponsored-by: British Museum Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Added sponsored by line, looking good now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|julian.maurice@biblibre.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183825|0 |1 is obsolete| | --- Comment #20 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 184663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184663&action=edit Bug 39489: 'Refine your search' aria-expanded attribute Beautiful work here! I love this patch and the QA tool is also happy. Passing QA here! On smaller screens (phones, tablets), the 'Refine your search' expandable section in the Koha OPAC is not clearly announced by screen readers. The reason for this is that the expandable section toggle button is instead identified and announced as a link. This results in screen reader users incorrectly expecting to be redirected to another page, and not being informed that there is a expandable section. For elements with a class of menu-collapse-toggle, add an aria-expanded attribute which defaults to false, and is toggled to true upon that specific section being expanded. If the screen width is 992px or higher, then remove the aria-expanded attribute on load as it is irrelevant, and potentially misleading. To test: 1) Apply the patch. on a small screen: 2) Run a library catalogue search in the Koha OPAC. 3) Right click on the page to inspect it. 4) Inspect the 'Refine your search' element. 5) Notice that it now has a aria-expanded attribute which is set to false. 6) Open the expandable 'Refine your search' section. 7) Notice that the aria-expanded attribute on the 'Refinine your search' element is now set to true. 8) Navigate to Home > Most popular titles 9) Repeat steps 3-7 10) Navigate to Home > Details for > Full subscription history 11) Repeat steps 3-7 then, on a bigger screen (992px and above) 12) Run a library catalogue search in the Koha OPAC. 13) Right click on the page to inspect it. 14) Inspect the 'Refine your search' element. 15) Notice that there is no 'aria-expanded' attribute, as in this case the section isn't expandable. 16) Resize your viewport below 992px, and notice that 'aria-expanded' reappears and is set to false. 17) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to false. 18) Open 'Refine your search', notice that 'aria-expanded' is set to true. 19) Resize your viewport while remaining below the 992px limit, and notice that 'aria-expanded' remains set to true. Note: now updated to handle screen resizes Sponsored-by: British Museum Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 --- Comment #22 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 24.11.x I propose to not backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39489 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #24 from David Nind <david@davidnind.com> --- Nothing to document for the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org