[Bug 25974] New: Remove inline style from columns settings administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Bug ID: 25974 Summary: Remove inline style from columns settings administration page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: alex.arnaud@biblibre.com, jonathan.druart@bugs.koha-community.org, mark.gavillet@ptfs-europe.com Depends on: 24156 Bug 24156 added some inline styles to columns_settings.tt which seem out of place. I'd prefer to remove the inline style and add some subtler CSS to the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 [Bug 24156] Basket - Make sort order and number of items to display configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove inline style from |Remove inline style from |columns settings |table settings |administration page |administration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106770&action=edit Bug 25974: Remove inline style from table settings administration page This patch removes an inline style attribute from the table settings administration template. A different style is added to the page's <style> block to try to accomplish a similar effect of expressing the hierarchy of the page. To test, apply the patch and go to Administration -> Table settings. The individual tables of settings should be offset from the headings above them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106770|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 106786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106786&action=edit Bug 25974: Remove inline style from table settings administration page This patch removes an inline style attribute from the table settings administration template. A different style is added to the page's <style> block to try to accomplish a similar effect of expressing the hierarchy of the page. To test, apply the patch and go to Administration -> Table settings. The individual tables of settings should be offset from the headings above them. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106786|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106853&action=edit Bug 25974: Remove inline style from table settings administration page This patch removes an inline style attribute from the table settings administration template. A different style is added to the page's <style> block to try to accomplish a similar effect of expressing the hierarchy of the page. To test, apply the patch and go to Administration -> Table settings. The individual tables of settings should be offset from the headings above them. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25974 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- missing a dependency for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org