[Bug 18753] New: t/00-testcritic.t fails Perl::Critic on test 221
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 Bug ID: 18753 Summary: t/00-testcritic.t fails Perl::Critic on test 221 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: ldjamison@marywood.edu QA Contact: gmcharlt@gmail.com Unit Test t/00-testcritic.t fails to pass Perl::Critic on Test 221. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris@bigballofwax.co.nz |ldjamison@marywood.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 --- Comment #1 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64090&action=edit Bug 18753 - t/00-testcritic fails Perl::Critic Bug Description: When performing a unit test on t/00-testcritic.t with the command 'prove t/00-testcritic.t' test 221 fails Perl::Critic with not ok 221 - Test::Perl::Critic for "reserve/request.pl" Failed test 'Test::Perl::Critic for "reserve/request.pl"' at /usr/share/perl5/Test/Perl/Critic.pm line 110. Perl::Critic found these violations in "reserve/request.pl": "$itemnumbers_of_biblioitem" is declared but not used at line 314, column 5. Unused variables clutter code and make it harder to read (Severity: 3) Cause of bug: The variable $itemnumbers_of_biblioitem is declared but never used in reserve/request.pl which causes the Perl::Critic violation. Patch Description: This patch removes the variable $itemnumbers_of_biblioitem from reserve/request.pl in order to satisfy Perl::Critic. The variable $itemnumbers_of_biblioitem is never used anywhere in reserve/request.pl other than its declaration so it should not cause any undesired effects. Test Plan: 1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'. 2) Test 221 fails. 3) Apply the patch. 4) Re-run 'prove t/00-testcritic.t'. 5) All of the tests pass now. 6) Quit out of koha-shell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |In Discussion --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- I think this is the wrong solution. The problem is that variable is used as a hash elsewhere. I think the problem is % vs $ not the variable name. Providing counter-patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64090|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64092&action=edit Bug 18753: t/00-testcritic.t fails TEST PLAN --------- $ export TEST_QA=1 $ sudo apt-get install libtest-perl-critic-perl $ prove t/00-testcritic.t -- test 221 will fail apply patch $ prove t/00-testcritic.t -- all tests will pass NOTE: Obsoleted Lee's patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64090|1 |0 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 64090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64090 Bug 18753 - t/00-testcritic fails Perl::Critic There actually is a hash declaration version earlier! DOH! This is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64090|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64093&action=edit Bug 18753 - t/00-testcritic fails Perl::Critic Bug Description: When performing a unit test on t/00-testcritic.t with the command 'prove t/00-testcritic.t' test 221 fails Perl::Critic with not ok 221 - Test::Perl::Critic for "reserve/request.pl" Failed test 'Test::Perl::Critic for "reserve/request.pl"' at /usr/share/perl5/Test/Perl/Critic.pm line 110. Perl::Critic found these violations in "reserve/request.pl": "$itemnumbers_of_biblioitem" is declared but not used at line 314, column 5. Unused variables clutter code and make it harder to read (Severity: 3) Cause of bug: The variable $itemnumbers_of_biblioitem is declared but never used in reserve/request.pl which causes the Perl::Critic violation. Patch Description: This patch removes the variable $itemnumbers_of_biblioitem from reserve/request.pl in order to satisfy Perl::Critic. The variable $itemnumbers_of_biblioitem is never used anywhere in reserve/request.pl other than its declaration so it should not cause any undesired effects. Test Plan: 1) Drop into koha-shell and run the command 'prove t/00-testcritic.t'. 2) Test 221 fails. 3) Apply the patch. 4) Re-run 'prove t/00-testcritic.t'. 5) All of the tests pass now. 6) Quit out of koha-shell. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18753 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry, missed that one. I have fixed it with commit b5b046599b6604c6cfd681d8392c560b3df738d2 Bug 18296: Remove perlcritic error (request.pl) *** This bug has been marked as a duplicate of bug 18296 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org