[Bug 16535] New: Add the date on which the suggestion was managed on Purchase suggestions tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Bug ID: 16535 Summary: Add the date on which the suggestion was managed on Purchase suggestions tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@ccsr.qc.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hi, It would be helpful if the date on wich the suggestion was managed was added on Purchase suggestions tab on borrower account. There is just who managed the suggestion. This can be as like date on table in suggestion.pl Regards Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980@gmail.com Assignee|koha-bugs@lists.koha-commun |arouss1980@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 55632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55632&action=edit Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab In the Staff client, under Patrons, the 'Purchase suggestions' tab for a patron does not include the date on which the suggestion was managed. If you follow a different route and go to Acquisitions > Suggestions, then the date is shown. This patch adds that enhancement (and fixes an open <td> tag, too). Test plan: 0) [PREREQUISITES] Create a suggestion and manage it, i.e. edit it a bit. 1) Go to Patrons and search for a patron whose suggestion has been managed. In the 'Purchase suggestions' tab for the patron, notice how the third column only lists _who_ managed the suggestion but not _when_. 2) Apply the patch. 3) Repeat step 1). The date the suggestion was managed should be displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55632|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 55894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55894&action=edit Bug 16535 - Add the date on which the suggestion was managed on Purchase suggestions tab In the Staff client, under Patrons, the 'Purchase suggestions' tab for a patron does not include the date on which the suggestion was managed. If you follow a different route and go to Acquisitions > Suggestions, then the date is shown. This patch adds that enhancement (and fixes an open <td> tag, too). Test plan: 0) [PREREQUISITES] Create a suggestion and manage it, i.e. edit it a bit. 1) Go to Patrons and search for a patron whose suggestion has been managed. In the 'Purchase suggestions' tab for the patron, notice how the third column only lists _who_ managed the suggestion but not _when_. 2) Apply the patch. 3) Repeat step 1). The date the suggestion was managed should be displayed. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think it would be better to add this info to its own column to allow sort on it, don't you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
I think it would be better to add this info to its own column to allow sort on it, don't you think?
Hum not sure actually, it's how it's displayed on the suggestion list page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #4)
(In reply to Jonathan Druart from comment #3)
I think it would be better to add this info to its own column to allow sort on it, don't you think?
Hum not sure actually, it's how it's displayed on the suggestion list page.
The way the patch displays the date is fine for me. A date colum would be fine as well, but if we add a date column, we should do the same on the suggestion list page to have the same look & feel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I think the addition of a new column for the date would be a good change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If we want to stick with this patch, we should fix the following bug: If the date does not exist, the cell contains: "name - " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #8 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #7)
If we want to stick with this patch, we should fix the following bug: If the date does not exist, the cell contains: "name - "
Can that ever happen? I had to delete the date directly in mysql to test this case (setting the date to '' and to NULL). If there is no date, the column displays nothing (with and without patch). On /suggestion/suggestion.pl, the column shows ' - ' (no name, no date, only the -) But if somebody adds a date column, I'll be happy to sign off :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have plenty of them and the check exist in suggestion.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Patrick Robitaille <patrick.robitaille@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@ccsr.qc. | |ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Abbey Holt <aholt@dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt@dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 --- Comment #10 from Abbey Holt <aholt@dubuque.lib.ia.us> --- Our staff would love a sortable column for date managed and date suggested in the borrower view. Hopefully this is still a possibility! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This has been added by bug 24585. *** This bug has been marked as a duplicate of bug 24585 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org