[Bug 7280] New: can't place hold without selecting on list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Bug #: 7280 Summary: can't place hold without selecting on list Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/opac-shelves.pl?viewshelf=3&sortfield= OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com When on a list if you click the place hold link below a title it says 'no item selected' but that error should only appear if you try to place a hold on multiple items using the place hold link at the top of the list. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |oleonard@myacpl.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-11-30 17:53:36 UTC --- Created attachment 6475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6475 Proposed fix JavaScript was looking for clicks on links with class "hold," and incorrectly triggering the check for checked checkboxes. Making the selection stricter lets the JS function as it should while allowing people to place individual holds directly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff Summary|can't place hold without |Can't place hold without |selecting on list |selecting on list -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6475|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-01 08:12:36 UTC --- Created attachment 6484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6484 Bug 7280 - can't place hold without selecting on list JavaScript was looking for clicks on links with class "hold," and incorrectly triggering the check for checked checkboxes. Making the selection stricter lets the JS function as it should while allowing people to place individual holds directly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-01 12:49:07 UTC --- Template only change, easy to read, marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_4 Patch Status|Passed QA |Patch Pushed Severity|major |normal --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 17:57:19 UTC --- patch pushed, please test I had some trouble reproducing the error: it was because I tried to click on the "hold" button below the title when at least one checkbox was checked. In this case, the message was not appearing ! (severity lowered to "normal", it was easy to place a hold even with this bug) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6484|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-12 18:29:31 UTC --- Created attachment 7579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7579 [SIGNED-OFF] Bug 7289: Adds editionstatement field in neworderempty Tested: Database update - existing mapping - no pre existing mapping Frameworks PROBLEM: some languages are still missing, I think only untranslated frameworks are included in this patch. Acquisition - created a new order with edition filled out - checked edition was saved to the correct field in cataloguing - modified edition and checked display in acquisition - edition also displays on basket summary page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-12 18:29:47 UTC --- Created attachment 7580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7580 Bug 7289: Add biblioitems.editionstatement to missing sql files Follow-up for 7289 adding the new mapping to translated frameworks. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-12 18:30:22 UTC --- Created attachment 7581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7581 [SIGNED-OFF] Bug 7289: Adds editionstatement field in neworderempty Tested: Database update - existing mapping - no pre existing mapping Frameworks PROBLEM: some languages are still missing, I think only untranslated frameworks are included in this patch. Acquisition - created a new order with edition filled out - checked edition was saved to the correct field in cataloguing - modified edition and checked display in acquisition - edition also displays on basket summary page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7579|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7580|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7581|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6484|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org