[Bug 16045] New: Use Font Awesome icons in OAI sets administration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Bug ID: 16045 Summary: Use Font Awesome icons in OAI sets administration Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/oai_sets.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are some links on the OAI administration pages which are styled with background images. These can be updated to use Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16014, 15991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 [Bug 15991] Moving OAI sets actions into a drop-down menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 [Bug 16014] OAI sets can be deleted without warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48969&action=edit Bug 16045 - Use Font Awesome icons in OAI sets administration There are links on the OAI sets administration page which can use Font Awesome icons instead of being styled with background images. This patch makes that change. Another minor change: Added the "fa-fw" class to items in the "Actions" menu which didn't have it. This helps the items line up correctly: http://fortawesome.github.io/Font-Awesome/examples/#fixed-width To test, apply the patches for Bugs 16014 and 15991 if necessary. Apply this patch and: - Go to Administration -> OAI sets configuration. - Click the "New set" button and verify that the "Add description" link uses a Font Awesome icon. - Confirm that the "Add description" link works correctly. - After adding a description, verify that the "Remove" link looks correct and works correctly. - From the list of OAI sets choose "Define mappings" from the "Actions" menu. - Confirm that the "Delete" button is styled correctly and works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48969|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48977&action=edit [SIGNED-OFF] Bug 16045 - Use Font Awesome icons in OAI sets administration There are links on the OAI sets administration page which can use Font Awesome icons instead of being styled with background images. This patch makes that change. Another minor change: Added the "fa-fw" class to items in the "Actions" menu which didn't have it. This helps the items line up correctly: http://fortawesome.github.io/Font-Awesome/examples/#fixed-width To test, apply the patches for Bugs 16014 and 15991 if necessary. Apply this patch and: - Go to Administration -> OAI sets configuration. - Click the "New set" button and verify that the "Add description" link uses a Font Awesome icon. - Confirm that the "Add description" link works correctly. - After adding a description, verify that the "Remove" link looks correct and works correctly. - From the list of OAI sets choose "Define mappings" from the "Actions" menu. - Confirm that the "Delete" button is styled correctly and works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48977|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48999&action=edit Bug 16045 - Use Font Awesome icons in OAI sets administration There are links on the OAI sets administration page which can use Font Awesome icons instead of being styled with background images. This patch makes that change. Another minor change: Added the "fa-fw" class to items in the "Actions" menu which didn't have it. This helps the items line up correctly: http://fortawesome.github.io/Font-Awesome/examples/#fixed-width To test, apply the patches for Bugs 16014 and 15991 if necessary. Apply this patch and: - Go to Administration -> OAI sets configuration. - Click the "New set" button and verify that the "Add description" link uses a Font Awesome icon. - Confirm that the "Add description" link works correctly. - After adding a description, verify that the "Remove" link looks correct and works correctly. - From the list of OAI sets choose "Define mappings" from the "Actions" menu. - Confirm that the "Delete" button is styled correctly and works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 [Bug 16080] Remove unused images from the staff client -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org