[Bug 15706] New: Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Bug ID: 15706 Summary: Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com For instance, in cat-search.inc, the checkin box is wrapped with [% IF ( CAN_user_circulate ) %] yet a librarian with only CAN_user_circulate_circulate_remaining_permissions should be able to see the box, as checkins only require circulate_remaining_permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12051 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47485&action=edit Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12051 CC| |aleishaamohia@hotmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 [Bug 12051] add renew tab to top on staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47485|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 47486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47486&action=edit Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- With a patron without circulate_remaining_permissions, but another subperm of circulate, I get 2 inputs on the mainpage: Enter patron card number or partial name: [+] Enter patron card number or partial name: And 2 tabs Search patrons Search the catalog -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47486|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47531&action=edit Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 --- Comment #6 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 47532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47532&action=edit Bug 15706: Forgot to attach the change I made! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47532|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47596&action=edit Bug 15706: Forgot to attach the change I made! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47531|0 |1 is obsolete| | Attachment #47596|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47786&action=edit Bug 15706: Changing to circulate_remaining_permissions I have only changed this in the includes for the tabs at the top. Dependent on Bug 12051 as that patch adds extra tabs to the top which would need to be changed later To test: 1) Apply Bug 12051 first, then this patch 2) Ensure that Check Out/Check In/Renew tabs still work as they should 3) Check patch for errors or pages I've missed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47787&action=edit Bug 15706: (follow-up) Changing to circulate_remaining_permissions Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 48728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48728&action=edit [3.22] Bug 15706: Changing to circulate_remaining_permissions Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #13 from Frédéric Demians <frederic@tamil.fr> --- This patch doesn't apply properly on 3.20 branch. Since 17 files are affected, I can't take the risk to fix the merging issues. Can the author of the patch propose a version for 3.20? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org