[Bug 23821] New: Reintroduction of create_helper_biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 Bug ID: 23821 Summary: Reintroduction of create_helper_biblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 7614, 21798 create_helper_biblio subroutines have been remove from bug 21798, but one occurrence have been reintroduced by bug 7614. We must use build_sample_biblio instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 [Bug 7614] Use branch transfer limits for determining available opac holds pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 [Bug 21798] We need t::lib::TestBuilder::build_sample_biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94270&action=edit Bug 23821: Remove new occurrence of create_helper_biblio create_helper_biblio subroutines have been remove from bug 21798, but one occurrence have been reintroduced by bug 7614. We must use build_sample_biblio instead. Test plan: prove t/db_dependent/Koha/Libraries.t should return green. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94270|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 94296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94296&action=edit Bug 23821: Remove new occurrence of create_helper_biblio create_helper_biblio subroutines have been remove from bug 21798, but one occurrence have been reintroduced by bug 7614. We must use build_sample_biblio instead. Test plan: prove t/db_dependent/Koha/Libraries.t should return green. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23821 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org