[Bug 22368] New: suggestions lacks foreign key constraints.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Bug ID: 22368 Summary: suggestions lacks foreign key constraints. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- The suggestions table, and code that relies upon it, assumes a series of relationships exist to other tables, however few of these are enforced at the database level.. we should add foreign key constraints for these. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85278&action=edit Bug 22636: Add missing constraints to `suggestions` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85279&action=edit Bug 22368: Add missing constraints to `suggestions` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85279|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85282&action=edit Bug 22368: Add missing constraints to `suggestions` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85283&action=edit Bug 22368: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85282|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85286&action=edit Bug 22368: Add missing constraints to `suggestions` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85283|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85287&action=edit Bug 22368: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22348 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22348 [Bug 22348] Koha::EDI has no tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Only issue with this now: it's noisy. Applied tests, and it failed as expected. Applied patch, and it passed, but it was noisier than expected. Is there any way to clean up the noise? I'm still going to sign off, but the noise is my only concern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85287|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 85309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85309&action=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85286|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 85310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85310&action=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've solved that noise somewhere before.. I'll have a hunt around and remind myself how and add it as a follow-up. Thanks for the SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|suggestions lacks foreign |Table suggestions lacks |key constraints. |foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cbrannon@cdalibrary.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I have no idea how to quiet those warnings.. perhaps a friendly QA person might add a QA followup and teach me how to do it ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85309|0 |1 is obsolete| | Attachment #85310|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85377&action=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85378&action=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85379&action=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 13533 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome, thanks for the followup.. I'll bank that one for next time :). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85388&action=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Madly enough.. I just found a typo in the second patch so I've fixed it with the QA follow-up.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 85388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85388 Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Review of attachment 85388: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22368&attachment=85388) ----------------------------------------------------------------- You meant extra. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hehe, well, one extra and one missing. 😉 It's so easy to make such a mistake in kohastructure during rebase.. I may try and write a test to catch such mistakes.. though that's for another bug and another day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 13484 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- C4::Installer::foreign_key_exists should be used here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- NOT IN could (must?) be replaced with LEFT JOIN table SET attr_a = NULL WHERE attr_b IS NULL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Regarding C4::Biblio::DelBiblio, suggestions_ibfk_biblionumber should ON DELETE CASCADE (instead of SET NULL). Same for suggestions_ibfk_branchcode? Marking as FQA/In discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #22)
C4::Installer::foreign_key_exists should be used here.
Happy to use this, though I used bug 21065 as an example.. do we need to fixup that one to use foreign_key_exists too? What do we win with the function vs my version.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #23)
NOT IN could (must?) be replaced with LEFT JOIN table SET attr_a = NULL WHERE attr_b IS NULL
Personally, I always find the NOT IN clearer than a LEFT JOIN.. and I thought the performance was pretty much the same as the mysql optimiser accounts for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #24)
Regarding C4::Biblio::DelBiblio, suggestions_ibfk_biblionumber should ON DELETE CASCADE (instead of SET NULL). Same for suggestions_ibfk_branchcode?
Marking as FQA/In discussion
I did wonder about these too... I was hoping to spark such discussion with the submission of this bug, so thanks. I'm happy to agree that 'deleting a biblio should also delete any suggestions attached to it' and 'deleting a branch should also delete any suggestions attached'.. Josef do you concur/have any opinion? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #27)
(In reply to Jonathan Druart from comment #24)
Regarding C4::Biblio::DelBiblio, suggestions_ibfk_biblionumber should ON DELETE CASCADE (instead of SET NULL). Same for suggestions_ibfk_branchcode?
Marking as FQA/In discussion
I did wonder about these too... I was hoping to spark such discussion with the submission of this bug, so thanks.
I'm happy to agree that 'deleting a biblio should also delete any suggestions attached to it' and 'deleting a branch should also delete any suggestions attached'.. Josef do you concur/have any opinion?
I think I'd prefer NULL in both cases as suggestions are perfectly fine without a branch and a biblionumber, both are optional right now. Deleting library: Should be a really rare case. I think at the moment we warn if there are patrons and items for the library before deleting. Should this be extended to cover suggestions as well? I think I'd prefer resetting to NULL (any library) to deleting. It seems the less dangerous and a patron from another library could have made the suggestion to begin with (or anonymous) and another library still might want to process it or inform the patron. Deleting biblio: This one is harder, I think I like NULL better, because the suggestion doesn't need the link, it's optional as it's only added when the suggestion is ordered. A use case where this might happen is: A patron makes a suggestion, it's ordered, it's 'sold out' and the order is cancelled deleting the record along with it. You might want to reset the status of the suggestion and try another vendor or inform the patron. I might think about this from the wrong direction, but maybe it adds to the discussion :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Martin Renvoize from comment #26)
(In reply to Jonathan Druart from comment #23)
NOT IN could (must?) be replaced with LEFT JOIN table SET attr_a = NULL WHERE attr_b IS NULL
Personally, I always find the NOT IN clearer than a LEFT JOIN.. and I thought the performance was pretty much the same as the mysql optimiser accounts for it.
I do find the NOT IN syntax more readable too.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #28)
(In reply to Martin Renvoize from comment #27)
(In reply to Jonathan Druart from comment #24)
Regarding C4::Biblio::DelBiblio, suggestions_ibfk_biblionumber should ON DELETE CASCADE (instead of SET NULL). Same for suggestions_ibfk_branchcode?
Marking as FQA/In discussion
I did wonder about these too... I was hoping to spark such discussion with the submission of this bug, so thanks.
I'm happy to agree that 'deleting a biblio should also delete any suggestions attached to it' and 'deleting a branch should also delete any suggestions attached'.. Josef do you concur/have any opinion?
I think I'd prefer NULL in both cases as suggestions are perfectly fine without a branch and a biblionumber, both are optional right now.
Deleting library: Should be a really rare case. I think at the moment we warn if there are patrons and items for the library before deleting. Should this be extended to cover suggestions as well? I think I'd prefer resetting to NULL (any library) to deleting. It seems the less dangerous and a patron from another library could have made the suggestion to begin with (or anonymous) and another library still might want to process it or inform the patron.
Deleting biblio: This one is harder, I think I like NULL better, because the suggestion doesn't need the link, it's optional as it's only added when the suggestion is ordered. A use case where this might happen is: A patron makes a suggestion, it's ordered, it's 'sold out' and the order is cancelled deleting the record along with it. You might want to reset the status of the suggestion and try another vendor or inform the patron.
I might think about this from the wrong direction, but maybe it adds to the discussion :)
I do prefer to SET NULL on both, as Katrin said, somebody can reuse it then... for example deleting it after deleting order and biblio is a side effect from my point of view - we are not working with suggestions and some suggestion can be deleted, even without a notice - it is weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22008 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13515 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85377|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85608&action=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85378|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85609&action=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85379|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85610&action=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85388|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85611&action=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85612&action=edit Bug 22368: (QA follow-up) Switch to using foreign_key_exists Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85608|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85723&action=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85609|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85725&action=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85610|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85726&action=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85611|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85727&action=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85612|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85728&action=edit Bug 22368: (QA follow-up) Switch to using foreign_key_exists Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85729&action=edit Bug 22368: (QA follow-up) Changed to LEFT JOIN as requested Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85723|0 |1 is obsolete| | Attachment #85725|0 |1 is obsolete| | Attachment #85726|0 |1 is obsolete| | Attachment #85727|0 |1 is obsolete| | Attachment #85728|0 |1 is obsolete| | Attachment #85729|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85739&action=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85739|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85742&action=edit Bug 22368: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85743&action=edit Bug 22368: Add missing constraints to `suggestions` Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85744&action=edit Bug 22368: (QA follow-up) Mute db errors in test Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85745&action=edit Bug 22368: (QA follow-up) Missing comma in kohastructure.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85746&action=edit Bug 22368: (QA follow-up) Switch to using foreign_key_exists Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85747&action=edit Bug 22368: (QA follow-up) Changed to LEFT JOIN as requested Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 85754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85754&action=edit Bug 22368: Make sure the tests will always pass Who knows! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vasanth.k@infoplus.co.in --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22756 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 22758 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22905 [Bug 22905] Edit suggestions - wrong branchcode behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #54 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think I have a blocker for 19.05, see bug 22905. suggestions.branchcode may be set to __ANY__ prior to this patch, and so the constraint will not be created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #55 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #54)
I think I have a blocker for 19.05, see bug 22905.
suggestions.branchcode may be set to __ANY__ prior to this patch, and so the constraint will not be created.
Nevermind, it will be set to NULL. Sorry for the noise! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 --- Comment #56 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- However bug 22905 is still valid, the suggestion will not be accepted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24244 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 [Bug 24244] Cannot create suggestion with branch set to 'Any' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org