[Bug 17854] New: Print Slip and Close button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Bug ID: 17854 Summary: Print Slip and Close button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Would like to see an enhancement on the clear screen (X) button on patron records. It would be great if it were replaced with a button with preference settings that would have the following options: Close Print Slip and Close Print Quick Slip and Close It would also be great if it could have a side action arrow giving you access to the other options that are not defaulted. This feature would help with staff closing accounts (clearing screen) when done, and making slip printing stand out a little better. It would also be a streamlined workflow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 79342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79342&action=edit Bug 17854: Adds print/close icon in checkout To Test: 1) Apply Patch. 2) Go to a patron checkout screen (circulation.pl). 3) Note there are no clear screen buttons in the upper right corner of the checkout window. 4) Turn on the DisplayClearScreenButton preference. 5) Go back to patron checkout. Note the clear screen button and the new printer icon next to it. 6) Click the printer icon. This will trigger a print slip function, and close the patron screen. 7) Try to arrow back to the previous screen. Should go to main menu and not the patron screen, just like the orginal close button (X). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- I have a patch ready for testing, however, this does not address all my requests. It does print the slip. It is the same function as the Print Slip choice. However, I know this does not address the issue if someone would rather print a quick slip and close. We could either: A) add another button next to the new button for a quick slip/close. or B) add a dropdown selector next to the button that would choose a default behavior and store the choice in a cookie. Option B is more complicated and I would need someone else to step in as I don't know a thing about cookies. I could easily do option A. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- BTW, when you load the patch, you will need to: $ yarn build to update the css. Without it, the button will not be in the correct place or have the correct look. Sandbox testers will not be able to test without this ability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- UPDATED TEST PLAN: 1) Apply Patch. 2) Run yarn build to update the css (Sorry sandbox testers!). 3) Go to a patron checkout screen (circulation.pl). 4) Note there are no clear screen buttons in the upper right corner of the checkout window. 5) Turn on the DisplayClearScreenButton preference. 6) Go back to patron checkout. Note the clear screen button and the new printer icon next to it. 7) Click the printer icon. This will trigger a print slip function, and close the patron screen. 8) Try to arrow back to the previous screen. Should go to main menu and not the patron screen, just like the orginal close button (X). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- See Comment 2 for discussion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Since the CircAutoPrintQuickSlip includes all the options you want, why not tie that preference to the DisplayClearScreenButton to get what you want? IF DisplayClearScreenButton is ON, clicking the clear screen button would trigger the action defined in CircAutoPrintQuickSlip. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79342|0 |1 is obsolete| | --- Comment #7 from Michal Denar <black23@gmail.com> --- Created attachment 79384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79384&action=edit Bug 17854: Adds print/close icon in checkout To Test: 1) Apply Patch. 2) Go to a patron checkout screen (circulation.pl). 3) Note there are no clear screen buttons in the upper right corner of the checkout window. 4) Turn on the DisplayClearScreenButton preference. 5) Go back to patron checkout. Note the clear screen button and the new printer icon next to it. 6) Click the printer icon. This will trigger a print slip function, and close the patron screen. 7) Try to arrow back to the previous screen. Should go to main menu and not the patron screen, just like the orginal close button (X). Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Owen Leonard from comment #6)
Since the CircAutoPrintQuickSlip includes all the options you want, why not tie that preference to the DisplayClearScreenButton to get what you want?
IF DisplayClearScreenButton is ON, clicking the clear screen button would trigger the action defined in CircAutoPrintQuickSlip.
Man! I didn't remember that. Wish someone mentioned it in the almost 2 years this was reported. I would have gone that route. But my button was pretty cute! :) I'll put this to a discussion and try an alternative patch with that suggestion. :) Thanks....OWEN. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Actually, I am going to put this back to needs signoff and go back to my question in comment 2. I don't want to pursue the CircAutoPrintQuickSlip preference, and here is why - It is an all or nothing setting. As a member of a consortium, this would be a problem. Not all our libraries have printers. Not everyone wants to print the same slip. That particular setting should have been incorporated under the library settings, or modified so that it could be set per library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79384|0 |1 is obsolete| | --- Comment #10 from Michal Denar <black23@gmail.com> --- Created attachment 79942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79942&action=edit Bug 17854: Adds print/close icon in checkout To Test: 1) Apply Patch. 2) Go to a patron checkout screen (circulation.pl). 3) Note there are no clear screen buttons in the upper right corner of the checkout window. 4) Turn on the DisplayClearScreenButton preference. 5) Go back to patron checkout. Note the clear screen button and the new printer icon next to it. 6) Click the printer icon. This will trigger a print slip function, and close the patron screen. 7) Try to arrow back to the previous screen. Should go to main menu and not the patron screen, just like the orginal close button (X). Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- Setting back to signed off, since no one has anything to say about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79942|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84472&action=edit Bug 17854: Adds print/close icon in checkout To Test: 1) Apply Patch. 2) Go to a patron checkout screen (circulation.pl). 3) Note there are no clear screen buttons in the upper right corner of the checkout window. 4) Turn on the DisplayClearScreenButton preference. 5) Go back to patron checkout. Note the clear screen button and the new printer icon next to it. 6) Click the printer icon. This will trigger a print slip function, and close the patron screen. 7) Try to arrow back to the previous screen. Should go to main menu and not the patron screen, just like the orginal close button (X). Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Print Slip and Close button |New Print slip and close | |button next to Close button CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds a 'Printer' button release notes| |next to the 'X' (clear) | |button when viewing a | |patron record - this allows | |the librarian to print a | |slip for the patron and | |clear their account form | |the screen to prevent | |viewing of information by | |another user or patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 [Bug 25658] Print icon sometimes obscures patron barcode -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org