[Bug 31265] New: Curbside pickups - improve slots selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Bug ID: 31265 Summary: Curbside pickups - improve slots selection Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30650 We should improve the slots selection. Is what is done at the OPAC enough? Staff: https://snipboard.io/qikxl3.jpg OPAC : https://snipboard.io/hULe5D.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 [Bug 30650] Convert the Curbside Pickup plugin to Koha core -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it's a little tidier and that improves orientation. But I agree there could be room for more enhancement. In the OPAC the entries are a little wide, maybe we could center the times as they are padded and have all the same size and decrease the width a little? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138405&action=edit Bug 31265: Improve time slots selection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am very bad at that. Owen, could you help me please? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138405|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138686&action=edit Bug 31265: Update style of time selection controls This patch updates the style of the time selection controls so that it is clearer that they are elements which the user can interact with. The times are now styled as buttons, and a check-mark icon is added when a time is selected. Also changed: Pickup date and notes fields are hidden until a library has been selected. The count of existing appointments has been removed in favor of showing the count of available appointments. A tooltip has been added: "Appointments available: X" I also changed the way the date selection event is fired. I found that jQuery's "change" event on the input itself was not reliable for some reason. I implemented instead an "onClose" event using the flatpickr instance. Note: The patch contains some indentation changes. To test, apply the patch and enable and configure curbside pickups if necessary. You should have at least two libraries with curbside hours defined. - Log in to the OPAC and go to "your curbside pickups." - Under the "Schedule a pickup" tab you should see only the option to select a library. - When you select a library the "Pickup date" field should appear. - When you select a date the time-selection buttons and the notes field should appear. - Hovering over a time should trigger the "Appointments available" tooltip. - Clicking a time should cause the "button" to turn green with a check-mark icon. - Submit a pickup request and confirm that it is saved correctly. - Return to the "Schedule a pickup" form and confirm that selecting the same library again triggers a message, "You already have a pickup scheduled for this library." - Select another library and another date. - Switch your library selection to the library you already have a request for. The date, time, and notes fields should be hidden again and the same message triggered about already having a pickup scheduled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks great, thx! Could we think of something similar for the staff interface? (almost feeling greedy :)) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138686|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138747&action=edit Bug 31265: Update style of time selection controls This patch updates the style of the time selection controls so that it is clearer that they are elements which the user can interact with. The times are now styled as buttons, and a check-mark icon is added when a time is selected. Also changed: Pickup date and notes fields are hidden until a library has been selected. The count of existing appointments has been removed in favor of showing the count of available appointments. A tooltip has been added: "Appointments available: X" I also changed the way the date selection event is fired. I found that jQuery's "change" event on the input itself was not reliable for some reason. I implemented instead an "onClose" event using the flatpickr instance. Note: The patch contains some indentation changes. To test, apply the patch and enable and configure curbside pickups if necessary. You should have at least two libraries with curbside hours defined. - Log in to the OPAC and go to "your curbside pickups." - Under the "Schedule a pickup" tab you should see only the option to select a library. - When you select a library the "Pickup date" field should appear. - When you select a date the time-selection buttons and the notes field should appear. - Hovering over a time should trigger the "Appointments available" tooltip. - Clicking a time should cause the "button" to turn green with a check-mark icon. - Submit a pickup request and confirm that it is saved correctly. - Return to the "Schedule a pickup" form and confirm that selecting the same library again triggers a message, "You already have a pickup scheduled for this library." - Select another library and another date. - Switch your library selection to the library you already have a request for. The date, time, and notes fields should be hidden again and the same message triggered about already having a pickup scheduled. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138759&action=edit Bug 31265: Use correct reply-to email when sending overdue mails Overdue emails are either sent from the issuing or the home library of an item. We never use the patron's home library, so the reply-to address must explicitly be set in EnqueueLetter. To test: - Set up 2 branches (A and B) with different email addresses. - Set up an SMTP server for each to use - Set up an overdue notice trigger for the patron category you'll use First letter: 1 day delay, any notice - Check out an item with home branch B to a patron from A - Run the the script with: overdue_notices.pl -t --frombranch item-homebranch overdue_notices.pl -t --frombranch item-issuebranch - Confirm for each setting that the correct email headers have been used. You can see the reply-to address and to-address in the message queue: SELECT * FROM message_queue; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |oleonard@myacpl.org |com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is certainly an improvement in my mind.. but it still feels a little out of place.. Shouldn't the 'Select a time' label be left aligned with the other form labels and the select options be aligned with the other inputs? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://snipboard.io/RbwMJa.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 138927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138927&action=edit Bug 31265: (QA follow-up) Align time selection controls like other inputs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138747|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138928&action=edit Bug 31265: Update style of time selection controls This patch updates the style of the time selection controls so that it is clearer that they are elements which the user can interact with. The times are now styled as buttons, and a check-mark icon is added when a time is selected. Also changed: Pickup date and notes fields are hidden until a library has been selected. The count of existing appointments has been removed in favor of showing the count of available appointments. A tooltip has been added: "Appointments available: X" I also changed the way the date selection event is fired. I found that jQuery's "change" event on the input itself was not reliable for some reason. I implemented instead an "onClose" event using the flatpickr instance. Note: The patch contains some indentation changes. To test, apply the patch and enable and configure curbside pickups if necessary. You should have at least two libraries with curbside hours defined. - Log in to the OPAC and go to "your curbside pickups." - Under the "Schedule a pickup" tab you should see only the option to select a library. - When you select a library the "Pickup date" field should appear. - When you select a date the time-selection buttons and the notes field should appear. - Hovering over a time should trigger the "Appointments available" tooltip. - Clicking a time should cause the "button" to turn green with a check-mark icon. - Submit a pickup request and confirm that it is saved correctly. - Return to the "Schedule a pickup" form and confirm that selecting the same library again triggers a message, "You already have a pickup scheduled for this library." - Select another library and another date. - Switch your library selection to the library you already have a request for. The date, time, and notes fields should be hidden again and the same message triggered about already having a pickup scheduled. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138927|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138929&action=edit Bug 31265: (QA follow-up) Align time selection controls like other inputs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Beautiful, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32652 [Bug 32652] Standardize slots selection between staff interface and opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31265 Bug 31265 depends on bug 30650, which changed state. Bug 30650 Summary: Add a curbside pickup module https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org