[Bug 36755] New: Increase length of 'code' column in borrower_attribute_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Bug ID: 36755 Summary: Increase length of 'code' column in borrower_attribute_types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Plugins may want to make use of patron attribute types thus prepending some data to the code of a patron attribute type they may need could be useful e.g. kitchensink_somefield. Currently, the 'code' is limited to VARCHAR(10) so this not possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166070&action=edit Bug 36755: Update UI input element -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166071&action=edit Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166071|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 166086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166086&action=edit Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166070|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 166087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166087&action=edit Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166086|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 166088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166088&action=edit Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Missing updates to kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166087|0 |1 is obsolete| | Attachment #166088|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166309&action=edit Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166310&action=edit Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166311&action=edit Bug 36755: Update kohastructure.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #9)
Created attachment 166311 [details] [review] Bug 36755: Update kohastructure.sql
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot kohastructure.sql. Although your follow-up seems to be missing the code column update on borrower_attribute_types! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #10)
(In reply to Kyle M Hall from comment #9)
Created attachment 166311 [details] [review] [review] Bug 36755: Update kohastructure.sql
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot kohastructure.sql.
Although your follow-up seems to be missing the code column update on borrower_attribute_types!
Can you please add it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166309|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166351&action=edit Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166310|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166352&action=edit Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166311|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166353&action=edit Bug 36755: Update kohastructure.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> PA amended: Squashed borrower_attribute_types table update Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #10)
(In reply to Kyle M Hall from comment #9)
Created attachment 166311 [details] [review] [review] Bug 36755: Update kohastructure.sql
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot kohastructure.sql.
Although your follow-up seems to be missing the code column update on borrower_attribute_types!
Thanks Pedro! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looks like I forgot the DBIC update, will push this to main now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This extends the release notes| |borrower_attribute_types.co | |de field from varchar(10) | |to varchar(64). This makes | |it easier to use also for | |plugins who might want to | |use unique prefixes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/899 Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36755 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40725 [Bug 40725] DBRev 23.12.00.053 should be made more resilient -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org