[Bug 10597] New: Search to hold button broken on record details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Bug ID: 10597 Summary: Search to hold button broken on record details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19696&action=edit Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19696|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 19702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19702&action=edit [SIGNED-OFF] Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Simple patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19702|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19760&action=edit Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for "search to hold". It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the "Place hold" button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! I note that there are two other staff templates that contain the text 'place hold for': ./modules/catalogue/results.tt ./modules/virtualshelves/shelves.tt Making a parameterized template to implement the widget would be a Good Thing for consistency's sake. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org