[Bug 6904] New: Suggestion status 'pending' and 'asked'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Bug #: 6904 Summary: Suggestion status 'pending' and 'asked' Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org While testing a patch for suggestions I wondered about the different terms used for 'fresh' suggestions. When you create a suggestion it goes into tab 'pending'. But the status for that is 'asked'. The naming should at least be consistent. Does 'asked' make sense? Perhaps we should rename it to something like 'suggested'? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-09-29 15:48:42 UTC --- I'd say it should be 'pending' everywhere. Why use diff language in diff places? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-30 05:07:16 UTC --- I think that too - it should be consistent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-13 05:35:57 UTC --- Created attachment 5872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5872 Bug 6904: Changes 'asked' to 'pending' in suggestions for more consistency In some places the suggestions were 'pending' in others the same status was named 'pending'. This patch changes the status to 'pending' in all places on the suggestion page to make it more consistent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5872|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-10-14 13:46:47 UTC --- Created attachment 5893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5893 [SIGNED-OFF] Bug 6904: Changes 'asked' to 'pending' in suggestions for more consistency In some places the suggestions were 'pending' in others the same status was named 'pending'. This patch changes the status to 'pending' in all places on the suggestion page to make it more consistent. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-17 19:26:02 UTC --- Simple template change, but introduces new strings. Marking as Passed QA; integration is up to RM. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 19:36:37 UTC --- This has been pushed: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=1576e3f410b3c491... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 19:37:41 UTC --- Patch has been pushed, but got the link from the wrong tab - correct link: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=087bb15e7003cb1f... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6904 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-29 14:53:44 UTC --- All instances of 'asked' are changed to 'pending' now on current master/3.6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org