https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tomas, do we have something to trigger ktd in this situation? I don't think so, we will need to do it manually. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I'm getting an error on yarn build: ERROR in /kohadevbox/koha/cypress.config.ts 17:8-20:9 [tsl] ERROR in /kohadevbox/koha/cypress.config.ts(17,9) TS2322: Type '{ devServer: { framework: string; bundler: string; }; }' is not assignable to type 'Partial<Omit<ResolvedConfigOptions, TestingType>>'. Object literal may only specify known properties, and 'devServer' does not exist in type 'Partial<Omit<ResolvedConfigOptions, TestingType>>'. ts-loader-default_0c5a263502dc9404 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It was missing the change from package.json (which I certainly dropped with yarn.lock before I submitted the first patch). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153952|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 153954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153954&action=edit Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 We are currently using 9.7.0. Since 10 the config file structure changed, and has been renamed cypress.json to cypress.config.ts https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypre... Also cypress-studio (used for bug 34076) is not working on 9.7.0. Test plan: yarn install yarn build mv /root/.cache/Cypress/12.17.2/ /kohadevbox/Cypress/ perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only You should not get any failures from the tests. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155097&action=edit Bug 34319: Fix dialog_spec.ts Follow the cypress upgrade instructions in the previous patch Run the tests, verify they fail Apply this patch, run tests again, verify they now pass -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #9)

Tests are passing for me without this patch.

Apply first patch only # inside ktd yarn install yarn build yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts

Cypress 12.17.4

Make sure you have 0 packages in your local DB. Restart yarn js:watch if it was already running. Run again: yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts Fails for me everytime. Alternatively, run cypress tests visually to make the issue obvious yarn run cypress open -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155097|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Comment on attachment 155097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155097 Bug 34319: Fix dialog_spec.ts This is fixing a random failure. It should be moved to its own bug report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I now triggered a manual KTD build: https://gitlab.com/koha-community/koha-testing-docker/-/pipelines/993420482 Things worked great locally. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #16)

Created attachment 155234 [details] [review] Bug 34319: (QA follow-up) Add cypress.config.ts to Makefile.PL mapping

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

But then I think we should remove cypress.json -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- May we backport this one ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I would recommend backporting this Fridolin, the cypress tests won't run without it -- You are receiving this mail because: You are watching all bug changes.