https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39497 --- Comment #1 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 180694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180694&action=edit Bug 39497: update 'Lists' page tabs attributes On the Koha OPAC, the 'Lists' page contains tabs which aren't clearly marked as such (no relevant attribute set on the element). This means that screen readers will not recognise the tabs as such, and screen reader users will not be made aware that these are available. Since the 'Advanced Search' page contains tabs that are correctly identified and described by screen readers, update the HTML atributes for the tabs on the 'Lists' page so that it matches theirs. Note: this is a quick and simple fix aiming to meet accessibility requirements. Another approach could be to implement wrappers (as in advsearch.tt), but it seems a bigger refactor of opac-shelves.tt may be needed to allow that. Test plan: 0) Before testing, ensure that the relevant patron has a few public and private lists. 1) Log in on the Koha OPAC 3) Navigate to Home > koha > Lists 2) Notice that, when the page first load, the 'Your Lists' tab panel is displayed (functionality is preserved) 3) Select 'Public lists', and notice that the tab panel now matches that (again, functionality is preserved) 4) Either inspect the page's HTML or run a Lighthouse test, and check that all aria attribute required by screen readers are present (aria attributes assumed to be required are aria-controls, aria-selected, and aria-labelledby. It is also assumed that 'role' attributes are needed) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39497 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39497 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180695|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180706&action=edit Bug 39497: update 'Lists' page tabs attributes On the Koha OPAC, the 'Lists' page contains tabs which aren't clearly marked as such (no relevant attribute set on the element). This means that screen readers will not recognise the tabs as such, and screen reader users will not be made aware that these are available. Since the 'Advanced Search' page contains tabs that are correctly identified and described by screen readers, update the HTML atributes for the tabs on the 'Lists' page so that it matches theirs. Note: this is a quick and simple fix aiming to meet accessibility requirements. Another approach could be to implement wrappers (as in advsearch.tt), but it seems a bigger refactor of opac-shelves.tt may be needed to allow that. Test plan: 0) Before testing, ensure that the relevant patron has a few public and private lists. 1) Log in on the Koha OPAC 3) Navigate to Home > koha > Lists 2) Notice that, when the page first load, the 'Your Lists' tab panel is displayed (functionality is preserved) 3) Select 'Public lists', and notice that the tab panel now matches that (again, functionality is preserved) 4) Either inspect the page's HTML or run a Lighthouse test, and check that all aria attribute required by screen readers are present (aria attributes assumed to be required are aria-controls, aria-selected, and aria-labelledby. It is also assumed that 'role' attributes are needed) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39497 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180706|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181713&action=edit Bug 39497: update 'Lists' page tabs attributes On the Koha OPAC, the 'Lists' page contains tabs which aren't clearly marked as such (no relevant attribute set on the element). This means that screen readers will not recognise the tabs as such, and screen reader users will not be made aware that these are available. Since the 'Advanced Search' page contains tabs that are correctly identified and described by screen readers, update the HTML atributes for the tabs on the 'Lists' page so that it matches theirs. Note: this is a quick and simple fix aiming to meet accessibility requirements. Another approach could be to implement wrappers (as in advsearch.tt), but it seems a bigger refactor of opac-shelves.tt may be needed to allow that. Test plan: 0) Before testing, ensure that the relevant patron has a few public and private lists. 1) Log in on the Koha OPAC 3) Navigate to Home > koha > Lists 2) Notice that, when the page first load, the 'Your Lists' tab panel is displayed (functionality is preserved) 3) Select 'Public lists', and notice that the tab panel now matches that (again, functionality is preserved) 4) Either inspect the page's HTML or run a Lighthouse test, and check that all aria attribute required by screen readers are present (aria attributes assumed to be required are aria-controls, aria-selected, and aria-labelledby. It is also assumed that 'role' attributes are needed) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Hard to apply on 24.11.x LTS Minor so I skip -- You are receiving this mail because: You are watching all bug changes.