[Bug 5403] New: C4::Koha::DisplayISBN should be wrapper for Business::ISBN->as_string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5403 Summary: C4::Koha::DisplayISBN should be wrapper for Business::ISBN->as_string Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: gmcharlt@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Now that Koha uses Business::ISBN, the handcrafted code for generating a display version of an ISBN should no longer be necessary -- DisplayISBN can just be a wrapper for Business::ISBN. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5403 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-12-13 18:26:55 UTC --- Actually the only place where DisplayISBN is used is in C4/Biblio to retrieve a publisher code. Therefore the routine (which did generate some oddly formatted iscns!) could be removed if Biblio uses Business::ISBN directly -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5403 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> 2010-12-14 09:31:14 UTC --- Actually The calling routine GetPublisherNameFromIsbn is not used either. Sent patch to remove both routines -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5403 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5403 --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-05 23:21:48 UTC --- This bug is mentioned in: Bug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn http://lists.koha-community.org/pipermail/koha-patches/2010-December/013268.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5403 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-17 06:46:56 UTC --- Pushed, please test NOTE this will break some unit tests, that is ok, I have purposefully done so so that I can use it for a teaching tool with my students tomorrow. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5403 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org