[Bug 34452] New: Button Update adjustments is hidden
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Bug ID: 34452 Summary: Button Update adjustments is hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sieber@kit.edu QA Contact: testopia@bugs.koha-community.org To recreate: 1. Go to acquisition modul 2. search for Vendor 3. Button receive shipment and create invoive 4. click finish receiving (we don't need an order line for this test) 5. Click +Add an adjustment 6. Enter an amount and save via Button 'Update adjustments' 7. Now change the amount 8. recognize that there is not button to save or update the changed amount The Button 'Update adjustments' is hidden, you first have to click on 'Add an adjustment' That is not intuitive and changed with Version 22.11 and the new UI. Check in older Koha Versions (e.g. 21.11) that the Button 'Update adjustments' was always visible underneath the Link to 'Add an adjustment'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #1 from Michaela Sieber <michaela.sieber@kit.edu> --- Created attachment 154130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154130&action=edit acqui/invoice.pl Hidden Button Update Adjustments Screenshot old vs. new UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com --- Comment #2 from Lisette Scheer <lisette.scheer@bywatersolutions.com> --- I believe this is related to changed made in Bug 32746. If you click the add an adjustment button and then make changes to your existing adjustment, it will let you save those, as a workaround until this is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 [Bug 32746] Standardize structure around action fieldsets in acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154281&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Summary|Button Update adjustments |Button 'Update adjustments' |is hidden |is hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 [Bug 33721] Show inactive funds in invoice.tt out of order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154281|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 154285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154285&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154285|0 |1 is obsolete| | --- Comment #5 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154310&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34492 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154310|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 154394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154394&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org