[Bug 5366] New: Standing enh req for code changes enabling database agnosticism
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Summary: Standing enh req for code changes enabling database agnosticism Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Database AssignedTo: gmcharlt@gmail.com ReportedBy: cnighswonger@foundations.edu QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Please include any specific databases code changes are made for in the comment section when updating this req and submitting patches. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-08 07:06:42 UTC --- Branch on git.koha-community.org/koha.git called new/enh/bug_5366 I will push any patches for this bug to that branch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #2 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-10 10:23:07 UTC --- This bug is mentioned in: [Bug 5366] Pull Request http://lists.koha-community.org/pipermail/koha-patches/2010-November/012839.... [Bug 5366] Pull Request [New Work] http://lists.koha-community.org/pipermail/koha-patches/2010-November/012936.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #3 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 13383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13383&action=edit Bug 5366 - Standing enh req for code changes enabling database agnosticism MariaDB apparently will not fudge when one attempts to insert a null value into a NOT NULL field with no default defined. This probably should have been fixed in any case, but must be fixed if Koha is to run over MariaDB. This patch simple supplies a single blank space as the value passed in on the initial insert. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 13384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13384&action=edit [2/2] Bug 5366 - Standing enh req for code changes enabling database agnosticism MariaDB apparently will not fudge when one attempts to insert a null value into a NOT NULL field with no default defined. This probably should have been fixed in any case, but must be fixed if Koha is to run over MariaDB. This patch simple supplies a single blank space as the value passed in on the initial insert. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #5 from Chris Nighswonger <cnighswonger@foundations.edu> --- These patches may or may not still be applicable. This work is quite old; however, I've attached them for posterity's sake if for nothing else. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13383|0 |1 is obsolete| | Attachment #13384|0 |1 is obsolete| | --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 13478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13478&action=edit Bug 5366 - Standing enh req for code changes enabling database agnosticism MariaDB apparently will not fudge when one attempts to insert a null value into a NOT NULL field with no default defined. This probably should have been fixed in any case, but must be fixed if Koha is to run over MariaDB. This patch simple supplies a single blank space as the value passed in on the initial insert. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 13479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13479&action=edit Bug 5366 - [2/2] Standing enh req for code changes enabling database agnosticism MariaDB apparently will not fudge when one attempts to insert a null value into a NOT NULL field with no default defined. This probably should have been fixed in any case, but must be fixed if Koha is to run over MariaDB. This patch simple supplies a single blank space as the value passed in on the initial insert. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13479|0 |1 is obsolete| | --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Created attachment 13480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13480&action=edit Bug 5366 - [2/2] Standing enh req for code changes enabling database agnosticism MariaDB apparently will not fudge when one attempts to insert a null value into a NOT NULL field with no default defined. This probably should have been fixed in any case, but must be fixed if Koha is to run over MariaDB. This patch simple supplies a single blank space as the value passed in on the initial insert. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)
These patches may or may not still be applicable. This work is quite old; however, I've attached them for posterity's sake if for nothing else.
hi Chris, i've just rebased them on master 411d8c3c8, (but i havent tested them yet) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Standing enh req for code |Koha does not work right |changes enabling database |with MariaDB |agnosticism | Severity|enhancement |major --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Chris, what are the symptoms of this problem? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> ---
Chris, what are the symptoms of this problem?
In other words, please supply a test plan. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #12 from Chris Nighswonger <cnighswonger@foundations.edu> --- Jared and I chated about this a bit on IRC. I do not have Koha running over MariaDB atm nor do I have the time to look back into this atm. So we can do one of two things: 1. Mark this bug WONTFIX because it appears at least one person cannot duplicate it. Or 2. Push the patches anyway because they net zero changes in the functionality of the code. Either way is fine with me. I'm sure if these represent real problems with MariaDB the bug will be reopened at some point in time. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Id like to test this, I kinda understand the commit message on the patch, so I will try to get time to test this. Ill put back to assigned, and will switch to needs signoff when i have mariadb going to test on. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- I now have Koha running under MariaDB, I am going to attempt to recreate the problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- I can recreate, to do so Install Mariadb (this will remove mysql) Koha will keep working fine Click around everything is good Try to add a biblio, you will end up on the additems screen, and a biblio has been created, but the biblioitem part failed, leaving your db a mess Apply the patch, try adding a new one again I get Can't call method "fields" on an undefined value at /home/chrisc/git/catalyst-koha/C4/Biblio.pm line 2509. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- It now inserts the biblioitem but explodes. I don't think we can push the patch as is. I switched back to mysql and get that same error, if I remove the patch, it works again -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #17 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #16)
It now inserts the biblioitem but explodes. I don't think we can push the patch as is.
I switched back to mysql and get that same error, if I remove the patch, it works again
I think that I remember now that you mention it that there were other problems which is probably why I did not pursue this further at the time. I seem to recall a discussion about the best way to approach a fix for the no null fields without a default could be fixed in the schema itself. Maybe fixing it there in all of its occurrences would fix the symptoms without breaking things too badly. But then if we have code expecting null values returned from some of these fields then things might just break anyway. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- As a data point, I'm currently running MariaDB 5.5.31, using mariadb.org's Debian Wheezy package. So far, I am *not* running into any glitches with inserting into tables that don't set explicit defaults for non-NULL columns. Here's an example session: MariaDB [koha]> CREATE TABLE foo ( -> id INTEGER auto_increment, -> field1 VARCHAR(50) NOT NULL, -> field2 TEXT NOT NULL, -> PRIMARY KEY (id) -> ) ENGINE=InnoDB DEFAULT CHARSET=utf8; Query OK, 0 rows affected (0.06 sec) MariaDB [koha]> INSERT INTO foo (field1) VALUES ('field1 set, field2 not'); Query OK, 1 row affected, 1 warning (0.00 sec) MariaDB [koha]> show warnings; +---------+------+---------------------------------------------+ | Level | Code | Message | +---------+------+---------------------------------------------+ | Warning | 1364 | Field 'field2' doesn't have a default value | +---------+------+---------------------------------------------+ 1 row in set (0.00 sec) MariaDB [koha]> INSERT INTO foo (field2) VALUES ('field2 set, field1 not'); Query OK, 1 row affected, 1 warning (0.03 sec) MariaDB [koha]> show warnings ; +---------+------+---------------------------------------------+ | Level | Code | Message | +---------+------+---------------------------------------------+ | Warning | 1364 | Field 'field1' doesn't have a default value | +---------+------+---------------------------------------------+ 1 row in set (0.00 sec) MariaDB [koha]> select * from foo; +----+------------------------+------------------------+ | id | field1 | field2 | +----+------------------------+------------------------+ | 1 | field1 set, field2 not | | | 2 | | field2 set, field1 not | +----+------------------------+------------------------+ 2 rows in set (0.00 sec) MariaDB [koha]> select * from foo where field2 is null; Empty set (0.00 sec) MariaDB [koha]> select * from foo where field2 = ''; +----+------------------------+--------+ | id | field1 | field2 | +----+------------------------+--------+ | 1 | field1 set, field2 not | | +----+------------------------+--------+ 1 row in set (0.00 sec) I wonder if, back when this was originally tested, whether MariaDB was shipping with a default value of SQL_MODE that included 'STRICT_TRANS_TABLES': ariaDB [koha]> SET SESSION sql_mode = 'STRICT_TRANS_TABLES'; Query OK, 0 rows affected (0.00 sec) MariaDB [koha]> INSERT INTO foo (field2) VALUES ('field2 set, field1 not'); ERROR 1364 (HY000): Field 'field1' doesn't have a default value If that's the case, perhaps a solution is to set SQL_MODE explicitly whenever Koha makes a database connection. The initial value would almost certainly have to be '', for compatibility reasons, but it would be a very worthy code to then start tightening the screws and work our way up to setting SQL_MODE to TRADITIONAL or the like -- and this would be an improvement regardless of whether any given Koha site uses MariaDB or MySQL. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #19 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #18)
As a data point, I'm currently running MariaDB 5.5.31, using mariadb.org's Debian Wheezy package.
So far, I am *not* running into any glitches with inserting into tables that don't set explicit defaults for non-NULL columns.
<snip>
I wonder if, back when this was originally tested, whether MariaDB was shipping with a default value of SQL_MODE that included 'STRICT_TRANS_TABLES':
ariaDB [koha]> SET SESSION sql_mode = 'STRICT_TRANS_TABLES'; Query OK, 0 rows affected (0.00 sec)
MariaDB [koha]> INSERT INTO foo (field2) VALUES ('field2 set, field1 not'); ERROR 1364 (HY000): Field 'field1' doesn't have a default value
This is entirely possible as this last error is what I was seeing.
If that's the case, perhaps a solution is to set SQL_MODE explicitly whenever Koha makes a database connection. The initial value would almost certainly have to be '', for compatibility reasons, but it would be a very worthy code to then start tightening the screws and work our way up to setting SQL_MODE to TRADITIONAL or the like -- and this would be an improvement regardless of whether any given Koha site uses MariaDB or MySQL.
This sounds like a good approach, and one which I would certainly support (fwiw). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 whobbie81-linuxgeek@yahoo.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |whobbie81-linuxgeek@yahoo.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Tom M <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13523 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Mason James from comment #6)
Created attachment 13478 [details] [review] Bug 5366 - Standing enh req for code changes enabling database agnosticism
The first patch will be useless with bug 13523. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 13480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13480 Bug 5366 - [2/2] Standing enh req for code changes enabling database agnosticism Review of attachment 13480: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5366&attachment=13480) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +1354,1 @@
A better would be to remove the NOT NULL condition in the DB structure for the import_records table. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis@yahoo.com --- Comment #22 from Manos PETRIDIS <egpetridis@yahoo.com> --- It seems not to be a MySQL/MiariaDB issue, but a koha one. If no nulls may be entered in a column, then the code should check for nulls and exclude such records from the import procedure, creating perhaps an exceprion report of records that failed the insertion criteria. If blanks are considered sufficient Information, then the code should check for nulls and convert them to empty strings (''). If on the other hand nulls are to be allowed as such, the column(s) should not have the NOT NULL attribute in the First place. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 --- Comment #23 from Marc Véron <veron@veron.ch> --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org