https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41283 Bug ID: 41283 Summary: Use a better diff viewer library Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org We use koha-tmpl/intranet-tmpl/lib/jsdiff/jsdiff.js from https://johnresig.com/projects/javascript-diff-algorithm/ for viewing diffs in the log viewer, patron merge, automatic updating of outdated reports, and MARC record diffs in batch imports. Unfortunately, it's a very elegant implementation of a not very robust diff algorithm. The simplest failure to see is that if you move a line from one spot in the thing being diffed to another spot, it won't detect any difference. So if someone changes if (wechecked) { dothething(); } to dothething(); if (wechecked) { } in IntranetUserJS, it will show an empty diff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.