[Bug 18556] New: Message "Patron's address in doubt" is confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Bug ID: 18556 Summary: Message "Patron's address in doubt" is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If a borrower has the patron account flag "Gone no address" set, the message "Patron's address in doubt" appears on the circulation check-out screen. This is confusing -- the borrowers table has the following fields that could be interpreted as an 'address' field: streetnumber streettype address address2 city state zipcode country B_streetnumber B_streettype B_address B_address2 B_city B_state B_zipcode B_country altcontactaddress1 altcontactaddress2 altcontactaddress3 altcontactstate altcontactzipcode altcontactcountry ... and it turns out that the message has *nothing* to do with any of these. I think that the message should read "Patron account flag 'Gone No Address' is set." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we should rename the flag too to make a bit easier to understand? Wrong address Wrong contact details Wrong address information ... ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140627&action=edit Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31562 Severity|enhancement |normal CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140627|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 140641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140641&action=edit Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like the change in wording, but I am in doubt about removing the circ-hlt class as it appears in the CSS and in other messages shown in the patron account, so it's something they have in common right now. Maybe we should keep it? And something odd with and without the patch: If you go to a patron account and set both flags, only the first has the list > in the beginning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
I like the change in wording, but I am in doubt about removing the circ-hlt class as it appears in the CSS and in other messages shown in the patron account, so it's something they have in common right now. Maybe we should keep it?
I don't remove it, it remains, one level down
And something odd with and without the patch: If you go to a patron account and set both flags, only the first has the list > in the beginning.
True before these patches too, something in the list markup maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140641|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142094&action=edit Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #5)
(In reply to Katrin Fischer from comment #4)
I like the change in wording, but I am in doubt about removing the circ-hlt class as it appears in the CSS and in other messages shown in the patron account, so it's something they have in common right now. Maybe we should keep it?
I don't remove it, it remains, one level down
This is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.08 |22.11.00, 22.05.08, released in| |21.11.15 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18556 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org