[Bug 8292] New: clicking ignore on hold cancels transfer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Priority: P5 - low Change sponsored?: --- Bug ID: 8292 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: clicking ignore on hold cancels transfer Severity: major Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha If a title has some holds on it and I check it in at the borrowing library, I got a message telling me about a hold. I clicked "Ignore" on that message. The barcode was not transferred back to the owning library at this point even though it should have been. The barcode still shows as having a Current Location. Notes from Ian on the code inspection: The portion of code that triggers the automatic return home is not called if a hold is found; this makes sense in the case where you're filling the hold, since you'd be transferring to that library instead of the home library. But when you 'ignore', nothing additional happens. The ignore button just makes the confirmation box disappear; not further actions are taken. So the code to do the transfer is never performed, and the item sits at the holdingbranch library. Obviously this is not what people expect. If you're ignoring the hold, you want the checkin to proceed as if the hold had never popped up in the first place, and that means doing a return home if appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12760&action=edit Bug 8292 - clicking ignore on hold cancels transfer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- CONFLICT (content): Merge conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12760|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14356&action=edit Bug 8292 - clicking ignore on hold cancels transfer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14356|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14474&action=edit Bug 8292 - Clicking ignore on hold cancels transfer Clicking 'ignore' in the hold confirmation box does nothing but make the confirmation box disappear. No further actions are taken. The code to do the transfer is never executed, and the item sits at the holdingbranch library. If you're ignoring the hold, you want the checkin to proceed as if the hold had never popped up in the first place, and that means doing a return home if appropriate. To test, place a hold on an item for delivery to Library A. Check that item in at Library B. Click "Ignore" in the hold confirmation message. Before the patch, doing so would simply trigger JavaScript to hide the dialog. After the patch the form will be sumitted and the item will be transfered without fulfilling the hold. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added description and test plan to the best of my understanding of what this patch is trying to accomplish based on the bug report. The patch works if I'm correct in my test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14474|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14841&action=edit [SIGNED-OFF] Bug 8292 - Clicking ignore on hold cancels transfer Clicking 'ignore' in the hold confirmation box does nothing but make the confirmation box disappear. No further actions are taken. The code to do the transfer is never executed, and the item sits at the holdingbranch library. If you're ignoring the hold, you want the checkin to proceed as if the hold had never popped up in the first place, and that means doing a return home if appropriate. To test, place a hold on an item for delivery to Library A. Check that item in at Library B. Click "Ignore" in the hold confirmation message. Before the patch, doing so would simply trigger JavaScript to hide the dialog. After the patch the form will be sumitted and the item will be transfered without fulfilling the hold. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added description and test plan to the best of my understanding of what this patch is trying to accomplish based on the bug report. The patch works if I'm correct in my test plan. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: 1) Add an item hold on an item from library B for a patron from library A, pickup location is library A 2) Check in item at library A 3) Click 'ignore' a) AutomaticItemReturn is ON = Koha provides a link to print the transfer slip. b) AutomaticItemReturn is OFF = Koha provides 3 options: Confirm transfer and print slip, confirm transfer, don't confirm transfer. Without the patch the item was returned, but the transfer wasn't triggered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I cannot get this problem to appear even without the patch. When I transfer the book from Library B, it gives me the option to ignore the hold. If I do that, nothing happens because the book is at library B. When the book arrives at library A, it does not give me the option of ignoring the hold because the book is already waiting. What am I missing here? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA CC| |liz@catalyst.net.nz --- Comment #7 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- I sign off on this after thorough testing of this scenario: Library A, B Patrons 1a, 2b (letters denote which branch the patron is from) Reserves 1, 2 Reserve 1 is placed for patron 2b Reserve 2 is placed for patron 3c Item is pulled from the shelf at library A (home library) Checked in, for hold for patron 2b Library clicks Confirm, sends item to B. B checks in the item Clicks "Ignore" Prompt says "Return to A" <- Good! Without the patch, this doesn't happen. However, and I think this is actually a different problem unrelated to this patch, but needs to be documented - Let's just say, that the staff member at B put it down on the desk (got interrupted) and another staff member picks up the book and checks it in again at library B. This is what they will see: http://i.imgur.com/AVGQTmK.png and in the detail: http://i.imgur.com/3z6K5iy.png What should this new staff member do and what are those messages actually trying to say? My point is, this patch greatly increases the likelihood of seeing dual prompts, and those prompts need to be made more understandable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14841|0 |1 is obsolete| | --- Comment #8 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Created attachment 14990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14990&action=edit Bug 8292 - Clicking ignore on hold cancels transfer Clicking 'ignore' in the hold confirmation box does nothing but make the confirmation box disappear. No further actions are taken. The code to do the transfer is never executed, and the item sits at the holdingbranch library. If you're ignoring the hold, you want the checkin to proceed as if the hold had never popped up in the first place, and that means doing a return home if appropriate. To test, place a hold on an item for delivery to Library A. Check that item in at Library B. Click "Ignore" in the hold confirmation message. Before the patch, doing so would simply trigger JavaScript to hide the dialog. After the patch the form will be sumitted and the item will be transfered without fulfilling the hold. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added description and test plan to the best of my understanding of what this patch is trying to accomplish based on the bug report. The patch works if I'm correct in my test plan. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: 1) Add an item hold on an item from library B for a patron from library A, pickup location is library A 2) Check in item at library A 3) Click 'ignore' a) AutomaticItemReturn is ON = Koha provides a link to print the transfer slip. b) AutomaticItemReturn is OFF = Koha provides 3 options: Confirm transfer and print slip, confirm transfer, don't confirm transfer. Without the patch the item was returned, but the transfer wasn't triggered. Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 --- Comment #9 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- I want to also note, that if the item is checked in at library A, the next hold isn't triggered at check in. That behaviour probably has something to do with bug 9322, and I believe it's longstanding behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9322 --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am not comfortable pushing this patch until the behavior the Liz describes in comment 9 is fixed (see also bug 9322, which Liz thinks may be the root cause of the unfillable holds issue). Right now, the behavior is annoying but predictable: click "Ignore," and the book isn't transferred. However, one can work around this by just sending the book where it belongs. With the patch, the book is transferred and -- so far as I can tell -- the next hold won't trigger at all, and I can't identify any workaround or think of a way to explain it to a librarian that will allow a multi-branch library to continue with business as usual. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Changing to "In Discussion" until bug 9322 is sorted out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> --- Just want to note that this happened again recently in Koha 3.14. Are we really discussing? or has this report been left to die? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nicole C. Engard from comment #12)
or has this report been left to die?
I don't think that's a helpful thing to say. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org