https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97668&action=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I tried to SO. There is one use left in test suite : $ git grep _get_itype t/db_dependent/Reserves.t:my $itype = C4::Reserves::_get_itype($item); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97668|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100968&action=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem UPDATE: In the meanwhile another occurrence was added to Reserves.t, but easy to replace Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100968|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 101315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101315&action=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem UPDATE: In the meanwhile another occurrence was added to Reserves.t, but easy to replace Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101315|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 101379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101379&action=edit Bug 24468: Remove unused C4::Reserves::_get_itype subroutine Since bug 21206, C4::Reserves::_get_itype is not longer used and should be removed. commit 31c29fd31f557306233e6a2936148a5bb10b89a1 Bug 21206: Replace C4::Items::GetItem UPDATE: In the meanwhile another occurrence was added to Reserves.t, but easy to replace Test plan: % git grep _get_itype must not return any occurrences. If one needs it, Koha::Item->effective_itemtype must be used instead. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.