[Bug 5402] New: "add to cart" shown on checkbox hover even if cart disabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5402 Summary: "add to cart" shown on checkbox hover even if cart disabled Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 On the OPAC search results page, when hovering over the checkbox next to each results "add to cart" is displayed in any of these three cases: 1. opacbookbag is on 2. virtualshelves is on 3. RequestonOPAC is on The message only makes sense in the first case, and should be different for the other two. The title attribute of the input should change depending on what system preferences are enabled and disabled. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5402 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2010-11-24 14:33:07 UTC --- Created attachment 2782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2782 Proposed fix This patch removes the title hint altogether. The checkbox might be used for the cart, lists, holds, or tags, and expressing this in a title hint seems overly complicated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5402 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5402 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5402 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Patch Pushed --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-30 21:31:46 UTC --- Patches pushed to master please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5402 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2010-11-30 21:33:54 UTC --- Tested. This patch resolves the bug. Closing ticket. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org