[Bug 31588] New: Update cpanfile for new OpenAPI versions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Bug ID: 31588 Summary: Update cpanfile for new OpenAPI versions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org CC: mtj@kohaaloha.com this bug tracks updating the cpanfile for new OpenAPI versions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 140794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140794&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (master) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #2 from Mason James <mtj@kohaaloha.com> --- Created attachment 140801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140801&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 140802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140802&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (21.11) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 140803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140803&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (21.05) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |lucas@bywatersolutions.com, | |tomascohen@gmail.com, | |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28926 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- CCing Arthur, I guess you meant to CC all RMaints. How to test? Idea: - for each branch, apply - push - wait for new container images to be built with this, ignore the automated batch of the CI run, it will be done on images out of date regarding this patch. See https://wiki.koha-community.org/wiki/Release_maintenance#Backporting_a_patch... - Rerun a bunch of builds manually - confirm they pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to Victor Grousset/tuxayo from comment #5)
CCing Arthur, I guess you meant to CC all RMaints.
How to test? Idea: - for each branch, apply - push - wait for new container images to be built with this, ignore the automated batch of the CI run, it will be done on images out of date regarding this patch. See https://wiki.koha-community.org/wiki/ Release_maintenance#Backporting_a_patch_with_a_new_perl_dependency - Rerun a bunch of builds manually - confirm they pass
to test: 1/ apply patch 2/ check 'modules' tab of about.pl page, all module versions should be white -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- No need for anything related to docker images? Ok, that's even easier. For 21.05.x I had: JSON::Validator (3.14) 3.14 Mojolicious::Plugin::OpenAPI (2.16) 2.16 and everything white except Locale::XGettext::TT2 Now I have JSON::Validator (3.14 - 3.99) 3.14 Mojolicious::Plugin::OpenAPI (2.16 - 2.99) 2.16 Is that was is expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I think there is a mistake in the patches for master and 22.05 - the version number for JSON:Validator has a comma in it instead of a full stop: requires 'JSON::Validator', '5,08'; master and 22.05 show in orange and as module upgrade needed for JSON::Validator (08) 5.08. JSON::Validator - 21.11: >=3.14, <=3.99 - OK, installed version shows as 3.14 - 21.05: >=3.14, <=3.99 - OK, installed version shows as 3.14 Mojolicious::Plugin::OpenAPI - master: 5.05 OK - 22.05: 5.05 OK - 21.11: >=2.16, <=2.99 - OK, installed version shows as 2.16 - 21.05: >=2.16, <=2.99 - OK, installed version shows as 2.16 The rough process I used for testing used with KTD (probably easier ways to do this) - repeat for all versions being updated (master to 21.05): Local git repository - check out the version of Koha being tested, for example: git checkout 22.05.x - create a branch: git checkout -B bz31588 KTD: - update .env so that KOHA_IMAGE reflects the version of Koha and patch being tested - start up KTD (images download) - apply the patch for the version of Koha being tested - check About Koha > Perl modules: module versions should reflect the patch and no warnings or errors, such as being highlighted in orange (module upgrade needed) - revert back to master (kshell, cd koha, git checkout [version being tested, e.g. 21.05.x], git branch -D bz31588, git reset --hard origin/[version being tested, e.g. 21.05.x], git checkout master, git branch -D [version being tested, e.g. 21.05.x], git reset --hard origin/master) (probably easier ways tod o this?) - shutdown KTD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140794|0 |1 is obsolete| | --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Created attachment 141558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141558&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140801|0 |1 is obsolete| | --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Created attachment 141559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141559&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to David Nind from comment #8)
I think there is a mistake in the patches for master and 22.05 - the version number for JSON:Validator has a comma in it instead of a full stop: requires 'JSON::Validator', '5,08';
oops, ive fixed the comma ',' :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141558|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 141561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141561&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141559|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 141562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141562&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140802|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 141563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141563&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (21.11) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140803|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 141564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141564&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (21.05) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from David Nind <david@davidnind.com> --- Have signed off. See comment #8 for how I tested - hope this is sufficient. Note that for Koha 21.05, Locale::XGettext::TT2 (0.7) shows as orange and Not Installed. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30252 --- Comment #17 from Mason James <mtj@kohaaloha.com> --- (In reply to David Nind from comment #16)
Have signed off.
See comment #8 for how I tested - hope this is sufficient.
Note that for Koha 21.05, Locale::XGettext::TT2 (0.7) shows as orange and Not Installed.
this will be fixed when bug 30252 is pushed to 21.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #18 from David Cook <dcook@prosentient.com.au> --- This should probably be renamed to "Update cpanfile for new Mojolicious::Plugin::OpenAPI versions" no? We're still using OpenAPI version 2 (and it looks like the new versions don't fully support OpenAPI version 3 anyway). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141561|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142364&action=edit Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.08 |22.11.00, 22.05.08, released in| |21.11.15 Status|Pushed to stable |Pushed to oldstable --- Comment #22 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31588 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #23 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org