[Bug 21229] New: Correct nesting and specificity for some button styles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Bug ID: 21229 Summary: Correct nesting and specificity for some button styles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 19474 There is an error in the nesting and specificity of some Bootstrap button-related styles. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77814&action=edit Bug 21229: Correct nesting and specificity for some button styles This patch corrects some Bootstrap button-related CSS which was causing some buttons to have the wrong color: - Circulation -> Check out: "Add a new message" link is black - Catalog -> Details page: "Print" button is blue To test, apply the patch and rebuild CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary and view the above pages to confirm the problem is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77814|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 77874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77874&action=edit Bug 21229: Correct nesting and specificity for some button styles This patch corrects some Bootstrap button-related CSS which was causing some buttons to have the wrong color: - Circulation -> Check out: "Add a new message" link is black - Catalog -> Details page: "Print" button is blue To test, apply the patch and rebuild CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary and view the above pages to confirm the problem is fixed. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77874|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77957&action=edit Bug 21229: Correct nesting and specificity for some button styles This patch corrects some Bootstrap button-related CSS which was causing some buttons to have the wrong color: - Circulation -> Check out: "Add a new message" link is black - Catalog -> Details page: "Print" button is blue To test, apply the patch and rebuild CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). Clear your browser cache if necessary and view the above pages to confirm the problem is fixed. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21229 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by bug 19474 not in 18.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org