https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #2 from Blou <philippe.blouin@inlibro.com> --- Created attachment 57731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57731&action=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #5 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 58263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58263&action=edit Bug - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58264|0 |1 is obsolete| | --- Comment #7 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 60925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60925&action=edit Bug 17674 - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #10 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61315&action=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #12 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- It works as described. I test with 1, 2, 3 issues deletion at one time asking for items to be deleting or not and the result is consistent :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #14 from Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> --- Created attachment 66565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66565&action=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley@catalyst.net.nz --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Can you please rebase against the master branch, when I apply the patches attached to this bug report I get the following merge error which is being thrown by the t/db_dependent/Serials.t file Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17674 - Allow UI to delete serials in batch Applying: Bug 17674 - Fix problem tabs Applying: Bug 17674 - Add unit tests Using index info to reconstruct a base tree... M t/db_dependent/Serials.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Serials.t CONFLICT (content): Merge conflict in t/db_dependent/Serials.t Failed to merge in the changes. Patch failed at 0001 Bug 17674 - Add unit tests The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17674---Add-unit-tests-yO9YMv.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61314|0 |1 is obsolete| | --- Comment #16 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69007&action=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61316|0 |1 is obsolete| | --- Comment #18 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69011&action=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #20 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- *** Bug 12575 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69010|0 |1 is obsolete| | --- Comment #22 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 69977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69977&action=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69013|0 |1 is obsolete| | --- Comment #24 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 69979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69979&action=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69976|0 |1 is obsolete| | --- Comment #26 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71865&action=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69978|0 |1 is obsolete| | --- Comment #28 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71867&action=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #30 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 71869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71869&action=edit Bug 17674 - Adapting Serials.t to the namespace change -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. You are not supposed to write SQL queries 2. You should read how Koha::Object-based objects work 3. method's names must be snake_case In short: forget the former C4 logic and rethink your new method. I can help you if you are stuck. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #33 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 72985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72985&action=edit Bug 17674 - Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Removed SQl and use snake_case. Same test plan as before. Might also want to test t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #35 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Séverine Queune from comment #34)

No conflict when applying the patch but I couldn't find where to find the new feature. Is it supposed to be on the /cgi-bin/koha/serials/serials-search.pl ? Or a new menu is created on Tools ?

Hi Severine, You have to go on serials-collection.pl?subscriptionid=?, you will see a button "Remove selected issue". See attached image. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #37 from Séverine Queune <severine.queune@bulac.fr> --- My bad, I confused myself between "serial" and "subscription" so I expected a different feature and was looking at the wrong place ! (It's been a hard hackfest week in Marseille ^^). Thanks a lot Marjorie ! I 'm going to test it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71865|0 |1 is obsolete| | --- Comment #38 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 73035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73035&action=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71867|0 |1 is obsolete| | --- Comment #40 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 73037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73037&action=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71869|0 |1 is obsolete| | --- Comment #42 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 73039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73039&action=edit Bug 17674 - Adapting Serials.t to the namespace change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #44 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Séverine Queune from comment #37)

My bad, I confused myself between "serial" and "subscription" so I expected a different feature and was looking at the wrong place ! (It's been a hard hackfest week in Marseille ^^). Thanks a lot Marjorie ! I 'm going to test it.

Great! Thanks for testing! Marjorie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting with a code review, patches apply, QA script passes: 1) Translatability issue + <h3>Are you sure delete <b> [% serialnumber %] </b> selected serials</h3> Please rethink this sentence. The <b> should not be used within a sentence as it will break this into several strings. I think it's not necessary here. Also sentence reads a bit strangely? :) Similar here: <h5>Number of items available <b>: [% countitems %] </b> </h5> That went well! Now testing: 2) I think if the serial is not set up to create items, we should not ask. Or if the number of items is 0. 3) A checkbox for deleting items would be a little nicer than the radio button. Could be fixed later, not blocker. 4) Number of items available : 0 No space there in English: available: 5) The appearing yellow dialogue pushes down the navigation bar on the right. Please check. Mostly tiny stuff, this looks quite good. Can you provide a quick follow-up and switch back to signed-off please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com --- Comment #48 from Roch D'Amour <roch.damour@inlibro.com> --- Hi Owen, did you forget to switch this back to "Need signoff"? It seems like your patch cover everything said Kat, yet the bug's status is still failed QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #51 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Owen Leonard from comment #47)

- Confirm that the "Delete selected" button works correctly. When serials of several years exist, only the button of the first tab works, not the buttons "Delete selected issues" displayed on the tabs of previous years. The other buttons work as expected on all tabs. Except that point, the rest of the patch works correctly, but I prefer not sign it.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow UI to delete serials |Allow UI to delete serials |in batch |issues in batch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74318|0 |1 is obsolete| | --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74472&action=edit Bug 17674 (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the <script> tags. To test, apply the patch and follow the original test plan. - Confirm that the "Delete selected" button works correctly. - Confirm that the confirmation dialog looks good and that its form elements work correctly. Edit: Make sure delete button works from any tab. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch no longer applies, can you please check? Maybe you did the last change without Owen's follow-up? Please also take a comment at c#55! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #56)

The patch no longer applies, can you please check?

The patches are out of order after my last update. "Remove delete related item checkbox when no items is available" should be applied after mine. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Roch, can you please provide a follow-up fixing the last issues? I'd like to retest before Friday deadline. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73036|0 |1 is obsolete| | --- Comment #61 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 75644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75644&action=edit Bug 17674: Fix problem tabs Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73038|0 |1 is obsolete| | --- Comment #63 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 75646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75646&action=edit Bug 17674: Move subroutine GetSerialItemsInformations to Koha/Serials.pm Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73040|0 |1 is obsolete| | --- Comment #65 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 75648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75648&action=edit Bug 17674: Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |david.bourgault@inlibro.com --- Comment #67 from David Bourgault <david.bourgault@inlibro.com> --- Rebased patches. I had to manually redo Owen's patch for some reason so I combined it with Roch's last patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75643|0 |1 is obsolete| | Attachment #75644|0 |1 is obsolete| | Attachment #75645|0 |1 is obsolete| | Attachment #75646|0 |1 is obsolete| | Attachment #75647|0 |1 is obsolete| | Attachment #75648|0 |1 is obsolete| | Attachment #75649|0 |1 is obsolete| | --- Comment #68 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77745&action=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #70 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77747&action=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #72 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77749&action=edit Bug 17674 - Adapting Serials.t to the namespace change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #74 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77751&action=edit Bug 17674 (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the <script> tags. To test, apply the patch and follow the original test plan. - Confirm that the "Delete selected" button works correctly. - Confirm that the confirmation dialog looks good and that its form elements work correctly. Edit: Make sure delete button works from any tab. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77745|0 |1 is obsolete| | Attachment #77746|0 |1 is obsolete| | Attachment #77747|0 |1 is obsolete| | Attachment #77748|0 |1 is obsolete| | Attachment #77749|0 |1 is obsolete| | Attachment #77750|0 |1 is obsolete| | Attachment #77751|0 |1 is obsolete| | --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77861&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77863&action=edit Bug 17674: Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77865&action=edit Bug 17674: Adapting Serials.t to the namespace change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77867&action=edit Bug 17674: (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the <script> tags. To test, apply the patch and follow the original test plan. - Confirm that the "Delete selected" button works correctly. - Confirm that the confirmation dialog looks good and that its form elements work correctly. Edit: Make sure delete button works from any tab. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've fixed the commit messages Bug XXXX: instead of Bug XXXX -. I've also added a tiny follow-up to fix the styling of the button and the wrong number of tests. Generally this works well, so I am signing off. Things to improve: - When deleting multiple issues and one is expected, the expected one is not deleted, which is, I think, the correct behaviour. Without the expected issue the subscription would no longer work correctly. But we could improve the visual by warning the user maybe. - When deleting issues that have no items yet, you are still offered the option to delete items with them (Status late for example). Nothing bad happens, so not blocker for me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77861|0 |1 is obsolete| | --- Comment #85 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 79420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79420&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77862|0 |1 is obsolete| | --- Comment #87 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 79422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79422&action=edit Bug 17674: Fix problem tabs Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77864|0 |1 is obsolete| | --- Comment #89 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 79424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79424&action=edit Bug 17674: Move subroutine GetSerialItemsInformations to Koha/Serials.pm Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77866|0 |1 is obsolete| | --- Comment #91 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 79426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79426&action=edit Bug 17674: Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79415|0 |1 is obsolete| | --- Comment #93 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 79428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79428&action=edit Bug 17674: (follow-up) Fix wrong number of tests, make button match visually -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79421|0 |1 is obsolete| | Attachment #79422|0 |1 is obsolete| | Attachment #79423|0 |1 is obsolete| | Attachment #79424|0 |1 is obsolete| | Attachment #79425|0 |1 is obsolete| | Attachment #79426|0 |1 is obsolete| | Attachment #79427|0 |1 is obsolete| | Attachment #79428|0 |1 is obsolete| | --- Comment #95 from Michal Denar <black23@gmail.com> --- Created attachment 79453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79453&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #97 from Michal Denar <black23@gmail.com> --- Created attachment 79455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79455&action=edit Bug 17674: Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS <sonia.bouis@univ-lyon3.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #99 from Michal Denar <black23@gmail.com> --- Created attachment 79457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79457&action=edit Bug 17674: Adapting Serials.t to the namespace change Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #101 from Michal Denar <black23@gmail.com> --- Created attachment 79459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79459&action=edit Bug 17674: (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the <script> tags. To test, apply the patch and follow the original test plan. - Confirm that the "Delete selected" button works correctly. - Confirm that the confirmation dialog looks good and that its form elements work correctly. Edit: Make sure delete button works from any tab. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #103 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments (reading the code): 1. I do not understand Koha::Serials::get_serial_items_count, several things are wrong: * you should not export, it must be a method and called like others: Koha::Module->method * my ( @self ) = @_; No, $self must be the object, then you pass the parameters. * + while ( my $s = $serialitems->next() ) { + $countitem++; + } => You actually want ->count * And finally, what is it supposed to do? and why? `git grep get_serial_items_count` returns only one occurrence: serials/serials-collection.pl:my @serialitemsinformation=get_serial_items_count(@ids); It returns an array of hashes (2 keys: countitems and serialid), countitems is used later, and serialid is not. Moreover I have no idea what the following is supposed to do 130 foreach my $line (@serialitemsinformation){ 131 DelItem($line); 132 } It certainly does not work. I would suggest you to rethink this as a method, for instance I am pretty sure you are looking for something like that: Koha::Serial->items which would return the items (Koha::Items!) for a given Koha::Serial object (already said, less explicitly, on comment 32) 2. You do not need to concat with '!' then split, you can pass several times a parameters (and retrieve them pl side with CGI->multi_param). It will simplify a lot the javascript code (function deleteIssues). 3. $delete and $confdelete should not be variables, but values of $op (usually "delete_confirm" and "delete_confirmed", see admin/cities.pl) 4. function generateReceive (serials-collection.tt) re-added, has been deleted previously by bug 18327. 5. Same for addsubscriptionid, delete by bug 19777. IMO it would be easier to redo these patches from scratch and abandon the too long patches history. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79454|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #105 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- All patches have been removed and will be replaced by a new one as suggested. It will take in account the last suggestions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80859|0 |1 is obsolete| | --- Comment #108 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 80944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80944&action=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #110 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Pierre-Marc, some things here: 1) Please make sure all your patches pass the QA script before submitting them: https://gitlab.com/koha-community/qa-test-tools Currently, it fails: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt FAIL filters missing_filter at line 380 ( deleteIssues("[% subscriptionidlist %]");) missing_filter at line 39 ( <h5>Number of items available: [% countitems %]</h5>) missing_filter at line 46 ( <input type="hidden" name="subscriptionid" value="[% subscriptionid %]" />) missing_filter at line 48 ( <input type="hidden" name="serialid" value="[% serialid %]" />) missing_filter at line 148 ( <input type="button" value="Delete selected issues" class="delete-issues btn btn-default btn-sm" data-subscriptionids="[% subscriptionidlist %]" />) missing_filter at line 36 ( <h3>You are about to delete [% serialnumber %] serial(s). Do you want to continue?</h3>) missing_filter at line 45 ( <input type="hidden" name="biblionumber" value="[% biblionumber %]" />) missing_filter at line 53 ( <input type="hidden" name="subscriptionid" value="[% subscriptionid %]" />) 2) Please make sure that the subject lines of your commits are formatted correctly. The QA script will also help with that: * Commit title does not start with 'Bug XXXXX: ' - 12463c45e7 3) Please make sure all text is translatable: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS2:_Enabling_transla... + alert("No serials selected"); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #113 from Séverine Queune <severine.queune@bulac.fr> --- Everything is correct when I deleted both serials and items, but I have a doubt about the behaviour when I keep the items : is it normal the 'Enumchron' field is emptied after deleting the linked serial ? I can't remember if it happened when I've previously tested it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #116 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- So... I find out when a serial is deleted with and without the patch, the enumchron lost only the date part. Maybe that was the observed problem, because otherwise the enumcron is not emptied. I will therefore proceed with the clearer test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #118 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- So... I find out when a serial is deleted with and without the patch, the enumchron lost only the date part. Maybe that was the observed problem, because otherwise the enumcron is not emptied. I will therefore proceed with the clearer test plan. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #120 from Séverine Queune <severine.queune@bulac.fr> --- Oups... Sorry, I still have the enumchron of the item emptied when I delete the serial. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #122 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Katrin Fischer from comment #121)

Could this be an UNIMARC vs. MARC21 issue? Which format did you use for testing Severine?

Unimarc. I tested with Biblibre's sandbox#1, patch is still applied if you want to take a look : I used the subscription "Psychologies" (Call number: SER4) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |maryse.simard@inlibro.com --- Comment #123 from Maryse Simard <maryse.simard@inlibro.com> --- I tried testing myself and could not reproduce the situation when the enumchron is emptied. I also tried testing with Biblibre's sandbox using Unimarc database and "Psychologies" subscription, but did not observe the problem. I wonder if I could trouble you for the exact steps you used to produce this error while testing? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86689|0 |1 is obsolete| | --- Comment #124 from Michal Denar <black23@gmail.com> --- Created attachment 95474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95474&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Test plan : - Apply patch. - Create at least four serials with items. - Notice that new items have a numbering pattern and a date in the enumchron field. - Use the button Delete selected issues for the following steps. - Delete a serial and its associated item. - Confirm the serial and item are gone. - Delete a serial and not its item. - Confirm the serial is gone. - Confirm the item is still there and the date part in the enumchron field is gone. - Delete the two lasts serials. - Confirm they are gone. Sponsored by : CCSR Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #126 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 99434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99434&action=edit Bug 17674: Handling of special cases This patch adds handling for those 2 particular cases: 1. Deleting the expected issue 2. Deleting a serial and it's item, but one item cannot be deleted To test: 1.1 Create a subscription that creates items 1.2 Receive two issues 1.3 Use the new button to delete the 'Expected' issue 1.4 The issue is correctly deleted, but the new expected issue created to replace the one which has been deleted don't have a published or received date and is show in it's own tab. 1.5 Apply patch 1.6 Repeat steps 1.1 through 1.4 => The new expected issue is created correctly 2.1 Use the same serial as in 1 or repeat step 1.1 and 1.2 2.2 Check out one of the items 2.3 Delete the corresponding serial and check box to delete items 2.4 The serial is deleted, but not the item. => No feedback is show to the user 2.5 Apply patch 2.6 Repeat step 2.1 through 2.4 => As before, the serial is deleted, but not the item => This time, an error is shown to inform the user -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95474|0 |1 is obsolete| | --- Comment #127 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 99944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99944&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Test plan : - Apply patch. - Create at least four serials with items. - Notice that new items have a numbering pattern and a date in the enumchron field. - Use the button Delete selected issues for the following steps. - Delete a serial and its associated item. - Confirm the serial and item are gone. - Delete a serial and not its item. - Confirm the serial is gone. - Confirm the item is still there and the date part in the enumchron field is gone. - Delete the two lasts serials. - Confirm they are gone. Sponsored by : CCSR Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: sonia <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #129 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- I've followed the test plan and everything looks Ok for me. 1. The next expected issue is correctly created when we delete the current expected issue. 2. If an item is checked out, you can't delete this item when you delete the serial issue. There's an alert to tell you that you can't delete the item. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #131 from Maryse Simard <maryse.simard@inlibro.com> --- (In reply to Jonathan Druart from comment #130)

I'd say you should not call DelItem directly, but DelItemCheck instead.

This is what has been done in the follow up patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99944|0 |1 is obsolete| | Attachment #99945|0 |1 is obsolete| | --- Comment #132 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100906&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Test plan : - Apply patch. - Create at least four serials with items. - Notice that new items have a numbering pattern and a date in the enumchron field. - Use the button Delete selected issues for the following steps. - Delete a serial and its associated item. - Confirm the serial and item are gone. - Delete a serial and not its item. - Confirm the serial is gone. - Confirm the item is still there and the date part in the enumchron field is gone. - Delete the two lasts serials. - Confirm they are gone. Sponsored by : CCSR Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #134 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Maryse Simard from comment #131)

(In reply to Jonathan Druart from comment #130)

...

I'd say you should not call DelItem directly, but DelItemCheck instead.

This is what has been done in the follow up patch.

Indeed! I forgot to squash before reviewing them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #135 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This allows to select release notes| |multiple issues to be | |deleted from the 'serial | |collection' page in the | |serials module. A checkbox | |allows to optionally delete | |linked items as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992 [Bug 26992] On serial collection page, impossible to delete issues and related items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #137 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 12157 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.