[Bug 17083] New: Remove more event attributes from tools templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Bug ID: 17083 Summary: Remove more event attributes from tools templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org This patch will remove event attributes from some tools-related templates: labels/label-edit-layout.tt tools/cleanborrowers.tt tools/inventory.tt tools/letter.tt tools/upload.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54199&action=edit Bug 17083 - Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54199|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 54244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54244&action=edit [SIGNED-OFF]Bug 17083: Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Event attributes removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54244|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 54435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54435&action=edit [PASSED QA] Bug 17083: Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Event attributes removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54435|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55750&action=edit [PASSED QA] Bug 17083: Remove more event attributes from tools templates This patch removes event attributes from several tool-related templates. Events are defined instead in the JavaScript. To test, apply the patch and: - Go to Tools -> Label creator -> Manage -> Layouts and edit any layout. - In the "Font" setting, choose any font which includes the word "italic" or "oblique" in the name. Doing so should disable the "Oblique title" checkbox. - Go to Tools -> Batch patron deletion/anonymization. - Submit the form without making any changes. You should be prompted to select an action. - Go to Tools -> Inventory. - Select a batch of barcodes to upload. - Submit the form without selecting any filters. This should trigger a warning. - Also changed: Added Font Awesome icons to the "Select all" and "Clear all" links on the inventory results view. - Go to Tools -> Notices and Slips. - Click "New notice" - Change the selection under "Koha module." The page should reload with the correct available message body fields. For instance, selecting "Holds" should make available reserves.* columns. - Go to Tools -> Upload. - In the search form, enter a search term and click the 'Search' button. The form should submit. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Event attributes removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17083 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18574 [Bug 18574] Clean Patron Records tool doesn't limit to the selected library -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org