http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chris@bigballofwax.co.nz AssignedTo|kyle.m.hall@gmail.com |chris@bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-25 21:43:52 UTC --- Working on this -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-25 22:56:22 UTC --- The note already shows I just marked a patron as restricted, and got Please note: Your account has been frozen. Usually the reason for freezing an account is old overdues or damage fees.If your account page shows your account to be clear, please contact the library. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-25 23:03:47 UTC --- Using the text of the note for expired also -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-08-26 00:02:05 UTC --- Chris, There is an override renewals limits preference (AllowRenewalLimitOverride), but it's specifically associated with the limit on number of renewals - not the fact that the patron is expired. Basically, what I think is being asked for here is if a patron is expired their account acts as if it's restricted and renewals, holds, checkouts are all blocked until the card is renewed by a librarian. This block should happen in both the OPAC and the staff client - otherwise, why have an expiration date? Make sense? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-09-06 19:32:23 UTC --- Chris, Are you asking me a question still? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-09-07 16:03:17 UTC --- OH! I see - it sounded like you were repeating my question. But i see what you're saying. I think that if they're expired they should be blocked all around - in the staff and the opac until the librarian addresses the expiration message. Right now only checkouts appear to be blocked, which is silly if you're not blocking the other actions. I'm up for others to chime in with their opinions. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-07 16:35:34 UTC --- I think renewals should not be possible for expired patrons. But perhaps allow holds so that they have a reason to go into the library and have their patron cards renewed? Might be more consistent though to block everything. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff AssignedTo|chris@bigballofwax.co.nz |chrish@catalyst.net.nz --- Comment #15 from Chris Hall <chrish@catalyst.net.nz> 2012-02-23 00:40:51 UTC --- Created attachment 7814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7814 Ability to block expired patrons placing OPAC reserves or holds on a system and category levels Patch attached Patch has a syspref and a setting in patron categories that allow you to configure blocking of OPAC actions (currently renew and reserve). Syspref is either block or don't block. Patron category settings are 'use syspref', 'block' and 'dont block' and will take priority over the syspref unless set to 'use syspref'. ~Chris H -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-03-01 07:05:20 UTC --- Hi Chris H., I was looking at your patch and I am a bit worried about the logic of the configuration options. The patron category now has a pull down with 3 settings: block, don't block, use syspref. And the system preference is block or don't block. When I am in the system preference editor, I have no way to find out, if my patron categories are affected by my changes. And when I am looking at patron categories I don't know what 'use syspref' will do. This seems confusing to me. Perhaps we could do it the other way around matching the behaviour of enhancedmessaging a bit? System preference: Block, Don't block, Configure on category type level Settings on patron category only show up when system preference is set to allow configuraton on category tyle level. For testing I fixed 2 small conflicts in your patch, be careful to keep the check on existence of dateexpiry when you rebase your patch. This was a recent change. Also the version number in updatedatabase should be XXX - this will make it easier for RM and is easier to test. With XXX you only have to update the kohaversion to the next higher number and the database update will happen. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7814|0 |1 is obsolete| | --- Comment #18 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 9108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9108&action=edit Ability to block expired patrons placing OPAC reserves or holds on a system and category levels Corrected patch to apply cleanly against master. Thanks for mentioning both the XXX and dateexpiry check Katrin. Thank you for your explanation of the alternative behavior, I am looking into this now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I tried setting this BlockExpiredPatronOpacActions to "block," but it doesn't seem to have any effect. I'm still able to place holds in the OPAC. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16061|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16063&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Use syspref" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16064|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16065&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- This should probably have another signer before getting a signed-off status. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> ---

Also, this patch has a huge amount of whitespace changes that appear to be unrelated to functional changes. I don't know if that is another cause to fail the patch, but it sure makes it harder to understand.

I'll take care of those changes. I had to make a lot of whitespace changes due to the fact that the code layout was a bit on the side of madness. "git diff -w" will hide changes that are just changes in indentation. I hope that is not cause alone for failing the patch. It's quite onerous to have to fix whitespace to understand the functioning of a script, undo those fixes, then make edits, then redo the fixes in a second patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16069|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16072&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chrish@catalyst.net.nz |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8236 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16072|0 |1 is obsolete| | --- Comment #32 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 17357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17357&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Rebased patch. Also made a change : Calling $query->param() into $template->param() is a bad idea, because $query->param() result type depends on context (normal or array contexts) and $template->param() is an array context. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #34 from Melia Meggs <melia@bywatersolutions.com> --- Hello, I applied the revised and followup patches together, but even with "Block expired patrons" set to "Block," I was still able to renew from the OPAC as an expired patron. I also discovered some strange behavior with renewing patrons while testing, but I'm not sure if it's related to this patch. Here's what happened: first I created a test patron and gave him an expiry date in the past. Then after going to the OPAC to test placing a hold, I realized that I would need to check something out to my patron so that I could test renewing an item from the OPAC. I couldn't check out to the expired test patron, so I tried to renew him. When I tried to renew the patron, things got weird. I got a message saying "Patron renewed until" with no date, but the warning "Patron expired" didn't go away. I then tried actually changing the expiry date from the patron record, but I still couldn't renew him. I had to switch back to master to renew my patron. Not sure if that is a consequence of this patch or not, but renewing the patron did seem to work fine in master. Thanks, Melia -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17463&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17464|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17466&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #39 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #14)

This is going to need to be one of those system-preferenced kind of things. There is no way every library is going to agree whether expired patrons should be any to do X but not Y and Z.

What we really need is patron permissions (CanBorrow, CanOPACRenew, CanOPACPlaceHold etc) on an individual basis, with defaults set by patron type like we do for message preferences, but with hooks/triggers that change this permissions under certain conditions (expired account, fines too high, too many overdues, etc).

Maybe I'm overlooking something obvious, but why are we letting an expired patron do "anything". This seems like a huge patch for something that should be straightforward, no? When logging into the OPAC, shouldn't we just check to see if the patron is expired, and if so...throw up a page that says "You're expired. Consult the staff at your library to be renewed" or something along those lines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #40)

As an example: I think in order to make them renew their account it can be good to allow holds. You see a book you want to get, place a hold on it, go to the library... renew your account. But that's something not every library might want to do this way, so it needs options.

I would argue that if a patron is restricted they should not be able to do anything, at least for something like lost cards. But that's another discussion probably. :)

Mmm, I see what you're saying now. That is rather obvious now that I think about it ;). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17466|0 |1 is obsolete| | --- Comment #43 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 17518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17518&action=edit [Signed off] Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs <melia@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #42)

1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac

At this step in the test plan I would expect that the summary of checkouts on opac-user.pl not show me checkboxes for performing renewals, or any of the other controls related to renewals. If I check a box and try to renew, I get a message that says " Please note: Your account renewal failed because of the following: " -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17908&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs <melia@bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17909&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17907|0 |1 is obsolete| | --- Comment #50 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18041&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18041|0 |1 is obsolete| | --- Comment #54 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19553&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18043|0 |1 is obsolete| | --- Comment #56 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19555&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #58 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Followup 3 needs signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19559|0 |1 is obsolete| | --- Comment #60 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19560&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 More infos in commit comment -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I know this has gone rounds for a while, but I can't get follow up 3 to apply after fixing the merge conflict in the first patch. Can someone please provide rebased patches? Thx! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19553|0 |1 is obsolete| | --- Comment #65 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19993&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19555|0 |1 is obsolete| | --- Comment #67 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19995&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19679|0 |1 is obsolete| | --- Comment #69 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19997&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches no longer apply, I fixed the conflict in sysprefs.sql in the first patch, but got stuck on opac.tt in the third. Can you please rebase? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19994|0 |1 is obsolete| | --- Comment #72 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 20642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20642&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 1 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19996|0 |1 is obsolete| | --- Comment #74 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 20644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20644&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Rebased master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this now... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21313&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21315&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 3 Installer fixes : - in kohastructure.sql, category.BlockExpiredPatronOpacActions default value is -1, sets the same in updatedatabase.pl - in syspref comment, replaces "opac actions such as placing a hold or reserve" by "opac actions such as placing holds or renrw books" - A 'YesNo' does not have 'yes' as value in database, it is '1'. - corrects small typo "categori" and syspref name case Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21317&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 5 - Fixes a typo in one of the OPAC messages: "you account" - Fixes the updatedatabase script to use 1 instead of yes for the system preference default matching the sysprefs.sql file. - Fixes capitalization "Don't Block" in system preference description. - Adding . to the end of the warning, when renewals are blocked. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is something that is quite annoying for some libraries and I feel like I have tested thoroughly (which probably means I missed something). So some automated regression tests would be very much appreciated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21312|0 |1 is obsolete| | Attachment #21313|0 |1 is obsolete| | Attachment #21314|0 |1 is obsolete| | Attachment #21315|0 |1 is obsolete| | Attachment #21316|0 |1 is obsolete| | Attachment #21317|0 |1 is obsolete| | --- Comment #89 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24385&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #91 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24387&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #93 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24389&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening <p> instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : <string> instead of <strong>, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #95 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24391&action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24385|0 |1 is obsolete| | Attachment #24386|0 |1 is obsolete| | Attachment #24387|0 |1 is obsolete| | Attachment #24388|0 |1 is obsolete| | Attachment #24389|0 |1 is obsolete| | Attachment #24390|0 |1 is obsolete| | Attachment #24391|0 |1 is obsolete| | Attachment #24392|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25158&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #99 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25160&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #101 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25162&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening <p> instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : <string> instead of <strong>, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #103 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25164&action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Rafal Kopaczka <rkopaczka@afm.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkopaczka@afm.edu.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25164|0 |1 is obsolete| | --- Comment #106 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25232&action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25165|0 |1 is obsolete| | --- Comment #107 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25233&action=edit Bug 6739: template changes for the bootstrap theme Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #108 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, there is a conflict I can't resolve in this patch series: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6739 - expired patrons not blocked from opac actions - Followup 2 fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6739 - expired patrons not blocked from opac actions - Followup 2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25158|0 |1 is obsolete| | Attachment #25159|0 |1 is obsolete| | Attachment #25160|0 |1 is obsolete| | Attachment #25161|0 |1 is obsolete| | Attachment #25162|0 |1 is obsolete| | Attachment #25231|0 |1 is obsolete| | Attachment #25232|0 |1 is obsolete| | Attachment #25233|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26546&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #111 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26548&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #113 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26550&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening <p> instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : <string> instead of <strong>, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #115 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26552&action=edit Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #117 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #108)

I am sorry, there is a conflict I can't resolve in this patch series:

Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing this again, please have a little patience. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #121 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26836&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Testing notes on last patch in series. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #123 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26838&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26840&action=edit [PASSED QA] Bug 6739 - expired patrons not blocked from opac actions - Followup 4 Some corrections : - opac-reserve.tt : opening <p> instead of closing - opac-user.tt : warnexpired was in database format, adds the use of KohaDates template plugin - opac-user.tt : duplicated TT test : [% IF ( BORROWER_INF.warnexpired ) %] and [% ELSIF ( BORROWER_INF.warnexpired ) %], maybe a merge error - opac-user.tt : <string> instead of <strong>, maybe for HTML 6 :-) - opac-user.pl : adding dateformat var to template is already done by Auth.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Testing notes: - Database update * Changes to kohastructure match changes done by the updatedatabase statement. Feature is activated by default. Fixing 'yes' to be '1' in a follow up. * Ran database update succesfully. * Note: Patrons are now blocked by default in new installations AND in updated installations. - System preference * Verified system preference shows up correctly. - Category configuration * Add new patron category * Edit existing patron category * Delete patron category * Check patron category summary table. => Verified all actions work as expected. => Verified chosen value for BlockExpiredPatronOpacActions' is always displayed and saved correctly. * Note: The new value is missing from the summary table. * Note: The new value is also not shown when deleting a patron category. - Check functionality * Renew and place a hold for an NOT EXPIRED patron with a) category: use syspref (default) syspref: block (default) b) category: use syspref (default) syspref: don't block c) category: block syspref: don't block d) category: block syspref: block e) category: don't block sypref: block * Verified renewals and placing holds were never blocked. * Also verified that the warning from NotifyBorrowerDeparture still shows up correctly. * Renew and place a hold for an EXPIRED patron with a) category: use syspref (default) syspref: block (default) => OK, both actions are blocked. b) category: use syspref (default) syspref: don't block => OK, both actions possible. c) category: block syspref: don't block => OK, both actions are blocked. d) category: block syspref: block => OK, both actions are blocked. e) category: don't block sypref: block => OK, both actions possible. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 2014-04-06 Update: Will repeat and amend above test plan on last patch in this series. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26842&action=edit [PASSED QA] Bug 6739: FIX conflicts with some others bugs. see comments 86 and 88. This patch fixes a bad conflict resolution in a previous patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26551|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins@cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #130 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Chris, Kyle, Fridolin, Katrin, and Jonathan! Note that I have elected to have the feature be OFF by default for upgrades. It will be on by default for new installations. -- You are receiving this mail because: You are watching all bug changes.