[Bug 38620] New: Non-existent hc-sticky asset included in opac-tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Bug ID: 38620 Summary: Non-existent hc-sticky asset included in opac-tags Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 36557, 36694 [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %] But it got removed by bug 36694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557 [Bug 36557] Improve logic and display of OPAC cart, tag, and lists controls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 [Bug 36694] Remove HC Sticky library in favor of CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175192&action=edit Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page This patch removes code intended to include the hc-sticky js library. hc-sticky is not longer included in Koha. To test, apply the patch and make sure the TagsEnabled system preference is turned on. Log in to the OPAC and go to the tags page. Everything should work correctly. There should be no errors in the developer console. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Is there something here that should be sticky? Toolbar, maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass (lukeg) from comment #2)
Is there something here that should be sticky? Toolbar, maybe?
From bug 36694:
OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- OK, nothing on the opac-tags looks like it needs to stick. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175192|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175196&action=edit Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page This patch removes code intended to include the hc-sticky js library. hc-sticky is not longer included in Koha. To test, apply the patch and make sure the TagsEnabled system preference is turned on. Log in to the OPAC and go to the tags page. Everything should work correctly. There should be no errors in the developer console. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175196|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 175197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175197&action=edit Bug 38620: Remove obsolete reference to hc-sicky on OPAC tags page This patch removes code intended to include the hc-sticky js library. hc-sticky is not longer included in Koha. To test, apply the patch and make sure the TagsEnabled system preference is turned on. Log in to the OPAC and go to the tags page. Everything should work correctly. There should be no errors in the developer console. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- It looks like this has been signed off and passed QA, but the status is still shown as "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #7)
It looks like this has been signed off and passed QA, but the status is still shown as "Needs Signoff".
Thanks David, I set it to "Signed-off". Jonathan can set to PQA so he gets credit. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass (lukeg) from comment #8)
(In reply to David Nind from comment #7)
It looks like this has been signed off and passed QA, but the status is still shown as "Needs Signoff".
Thanks David, I set it to "Signed-off". Jonathan can set to PQA so he gets credit. :)
Thanks Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes an obsolete release notes| |reference to the hc-sicky | |JavaScript library for the | |OPAC tags page - hc-sticky | |is no longer included in | |Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org