[Bug 24277] New: Date Received in acquisitions cannot be changed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Bug ID: 24277 Summary: Date Received in acquisitions cannot be changed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When receiving an order on orderreceive.pl, Koha gives one a date picker with which to change the Date Received. However, regardless of what one enters in the date picker today's date is used. To Test: - find/create an order ready for receipt - when receiving the order, set Date Received to something other than today's date - after receiving, check Receive Date in the Acquisitions tab of your bib (or query aqorders.datereceived), confirm it shows today's date I tried setting the shipment date on the invoice to something other than today, in case that made a difference, but it didn't help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Haven't tested, but could this change the items.dateaccessioned instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |13321, 8417 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables It removed datereceived from the arguments passed to ModReceiveOrder (wrong rebase resolution conflict I suspect). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 [Bug 8417] date acquired is shipping date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 [Bug 13321] Fix tax and prices calculation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96611&action=edit Bug 24277: Fix date received editing when receiving an order Bug 8417 added the ability to edit the date received, but a merge conflict was wrongly resolved during a rebase of commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables Test plan: Create an order Receive it Set a date (different from today) => The date you picked should have been set in DB for the order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96611|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96614&action=edit Bug 24277: Fix date received editing when receiving an order Bug 8417 added the ability to edit the date received, but a merge conflict was wrongly resolved during a rebase of commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables Test plan: Create an order Receive it Set a date (different from today) => The date you picked should have been set in DB for the order Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Works for me. Thanks for the quick patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 96614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96614 Bug 24277: Fix date received editing when receiving an order Review of attachment 96614: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24277&attachment=96614) ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ -1398,2 @@
received_itemnumbers => \@received_itemnumbers, - order_internalnote => $order_internalnote,
Was this change intentional? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #6)
Comment on attachment 96614 [details] [review] Bug 24277: Fix date received editing when receiving an order
Review of attachment 96614 [details] [review]: -----------------------------------------------------------------
::: C4/Acquisition.pm @@ -1398,2 @@
received_itemnumbers => \@received_itemnumbers, - order_internalnote => $order_internalnote,
Was this change intentional?
Yes, it's a POD update. It's not part of the param list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #7)
(In reply to Katrin Fischer from comment #6)
Comment on attachment 96614 [details] [review] [review] Bug 24277: Fix date received editing when receiving an order
Review of attachment 96614 [details] [review] [review]: -----------------------------------------------------------------
::: C4/Acquisition.pm @@ -1398,2 @@
received_itemnumbers => \@received_itemnumbers, - order_internalnote => $order_internalnote,
Was this change intentional?
Yes, it's a POD update. It's not part of the param list.
Oops, sorry. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96614|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96993&action=edit Bug 24277: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96994&action=edit Bug 24277: Fix date received editing when receiving an order Bug 8417 added the ability to edit the date received, but a merge conflict was wrongly resolved during a rebase of commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables Test plan: Create an order Receive it Set a date (different from today) => The date you picked should have been set in DB for the order Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02 |20.05.00, 19.11.02, released in| |19.05.08 CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.02, |20.05.00, 19.11.02, released in|19.05.08 |19.05.08, 18.11.14 CC| |hayleymapley@catalyst.net.n | |z Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.14. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org