[Bug 39365] New: `perl -cw` should pass on all Perl files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Bug ID: 39365 Summary: `perl -cw` should pass on all Perl files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 39324 The QA script is testing `perl -cw`. We need a test to catch regressions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39324 [Bug 39324] [OMNIBUS] All QA tests should pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179445&action=edit Bug 39365: Add tests We exclude (for now) some files that needs additional work: 1. Koha/Account/Credit.pm, Koha/Account/Debit.pm and Koha/Old/Hold.pm "Inconsistent hierarchy during C3 merge of class" 2. misc/translator/TmplTokenizer.pm Can't locate VerboseWarnings.pm in @INC We also ignore some known warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179446&action=edit Bug 39365: Fix 3 files Those 3 were failing but an easy fix can make them pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- The tests are quite slow however. We can discuss the need of this test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- *** This bug has been marked as a duplicate of bug 37245 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 [Bug 39325] Run codespell successfully on the whole codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Is there a new dependency here? I tried running the test and I'm getting an error: xt/pl_valid.t .. Can't locate Test/NoWarnings.pm in @INC (you may need to install the Test::NoWarnings module) I also get: Parse errors: No plan found in TAP output though I'm not sure if that's a separate error, or if it's just because the program fails before it reaches the plan tests line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Emily Lamancusa (emlam) from comment #5)
Is there a new dependency here? I tried running the test and I'm getting an error:
xt/pl_valid.t .. Can't locate Test/NoWarnings.pm in @INC (you may need to install the Test::NoWarnings module)
libtest-nowarnings-perl deps has been added by bug 38944. Please pull the latest ktd images or you can also manually install the debian package. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179445|0 |1 is obsolete| | --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 179740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179740&action=edit Bug 39365: Add tests We exclude (for now) some files that needs additional work: 1. Koha/Account/Credit.pm, Koha/Account/Debit.pm and Koha/Old/Hold.pm "Inconsistent hierarchy during C3 merge of class" 2. misc/translator/TmplTokenizer.pm Can't locate VerboseWarnings.pm in @INC We also ignore some known warnings. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179446|0 |1 is obsolete| | --- Comment #8 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 179741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179741&action=edit Bug 39365: Fix 3 files Those 3 were failing but an easy fix can make them pass Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Signing off because the test suite passes with the patches. I also fixed the file permissions on pl_valid.t inline, because xt/find-misplaced-executables.t was complaining. Testing notes (using KTD): 1. Start up KTD with selenium: ktd --selenium up 2. Install the new dependency: sudo cpanm Test::NoWarnings 3. Apply the patches. 4. Run all the tests: . ktd --shell --root . cd /kohadevbox/koha . perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179740|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180240&action=edit Bug 39365: Add tests We exclude (for now) some files that needs additional work: 1. Koha/Account/Credit.pm, Koha/Account/Debit.pm and Koha/Old/Hold.pm "Inconsistent hierarchy during C3 merge of class" 2. misc/translator/TmplTokenizer.pm Can't locate VerboseWarnings.pm in @INC We also ignore some known warnings. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179741|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180241&action=edit Bug 39365: Fix 3 files Those 3 were failing but an easy fix can make them pass Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Great to have this.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #15 from David Nind <david@davidnind.com> --- Test suite changes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39365 Abdivasiyev Sunnatillo <abdivasiyevsunnatillo2008@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abdivasiyevsunnatillo2008@g | |mail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org