[Bug 28573] New: Replace authority record with Z39.50/SRU creates new authority record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Bug ID: 28573 Summary: Replace authority record with Z39.50/SRU creates new authority record Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: sebastian.krieg@tuz-eisenach.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When replacing an authority record with Z39.50/SRU you get a new record and no update of the upgrading record. Test instance: Catalyst IT Ltd. (New Zealand) (https://koha-community.org/demo/) example record: #13 (name: Plato) Steps to reproduce: 1. Menu "Home > Authorities > Details for authority #13 (Personal Name)" 2. Form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/detail.pl?authid=13 3. Menu "Edit > Replace record via Z39.50/SRU" 4. Field "Name(any)": Homer >> Click "search" 5. choose the second entry "Aschmann, Homer, 1920-" >> click "import" Expected solution: - replace the record #13 with the search data "Aschmann, Homer, 1920-" - Form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/detail.pl?authid=13 Error: - Menu "Home > Authorities > Adding authority Personal Name" - form: https://demo-intra.mykoha.co.nz/cgi-bin/koha/authorities/authorities.pl?breedingid=58824&authtypecode=PERSO_NAME&index= - Save the record as Record #14 - Menu "Home > Authorities > Details for authority #14 (Personal Name)" Note: I found this error in release 21.05., I use a instance 20.11. to reproduce the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Sebastian Krieg <sebastian.krieg@tuz-eisenach.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P3 OS|All |Linux --- Comment #1 from Sebastian Krieg <sebastian.krieg@tuz-eisenach.de> --- Specify the fields "Hardware" and "Importance". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Volkan Sonmez <mvsonmez@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mvsonmez@gmail.com Version|20.11 |21.05 --- Comment #2 from Volkan Sonmez <mvsonmez@gmail.com> --- That is because authid parameter is missing in z3950_auth_search.tt. So authorities.pl think that this is new authority file but not modification. if you change <li><a href="/cgi-bin/koha/authorities/authorities.pl?breedingid=[% breeding_loo.breedingid | uri %]&authtypecode=[% breeding_loo.heading_code | uri %]&index=[% index | uri %]" class="chosen" title="Import"><i class="fa fa-download"></i> Import</a></li> line with <li><a href="/cgi-bin/koha/authorities/authorities.pl?breedingid=[% breeding_loo.breedingid | uri %]&authtypecode=[% breeding_loo.heading_code | uri %]&authid=[% breeding_loo.authid | uri %]&index=[% index | uri %]" class="chosen" title="Import"><i class="fa fa-download"></i> Import</a></li> in cataloguing/z3950_auth_search.tt file it will work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Sebastian Krieg <sebastian.krieg@tuz-eisenach.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Sebastian Krieg <sebastian.krieg@tuz-eisenach.de> --- Thank you for this workaround, it work's. Will this workaround include in the a next release? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Keywords| |Academy Severity|normal |major --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, if you change NEW to ASSIGNED this indicates that you plan on providing a patch for this issue. Better to leave it as new to alert devs there is still someone needed to fix this here. If you intend to provide a patch, please change back and also fill in the "Assignee" field. Right now this needs a developer to take it up in order to make it into a release. As the solution is already provided and tested, I am marking it Academy (easy ones for grab) and upping severity a bit as this would be likely to create unwanted duplicates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #5 from Sebastian Krieg <sebastian.krieg@tuz-eisenach.de> --- Hello, thanks for this information. It's OK. Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master CC| |gveranis@dataly.gr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from George Veranis <gveranis@dataly.gr> --- *** Bug 26776 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #7 from George Veranis <gveranis@dataly.gr> --- Created attachment 126130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126130&action=edit Bug28573: Replace authority record with Z39.50/SRU creates new authority record When trying to replace an authority record with Z39.50/SRU then a new authority record is created without deleting the old one and not link the new one with any record. This patch fixes that. Test plan: 1) Try to catalogue a new authority record from cataloguing form. 2) Try to replace that authority record with Z39.50/SRU, then a new authority record is created and also you have that one that you tried to replace. 3) Apply the patch. 4) Try to replace the authority from step1 with Z39.50/SRU, then is working as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps@biblibre.c | |om --- Comment #8 from Florian <florian.bontemps@biblibre.com> --- Does not seem to work. When replacing created authority with Z39.50/SRU after patch, it does replace the details of the authority but it does not change its title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126130|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 126178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126178&action=edit Bug28573: Replace authority record with Z39.50/SRU creates new authority record When trying to replace an authority record with Z39.50/SRU then a new authority record is created without deleting the old one and not link the new one with any record. This patch fixes that. Test plan: 1) Try to catalogue a new authority record from cataloguing form. 2) Try to replace that authority record with Z39.50/SRU, then a new authority record is created and also you have that one that you tried to replace. 3) Apply the patch. 4) Try to replace the authority from step1 with Z39.50/SRU, then is working as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Florian from comment #8)
Does not seem to work. When replacing created authority with Z39.50/SRU after patch, it does replace the details of the authority but it does not change its title.
I'm not sure I understand the issue you ran into. I tested this with a topical term subject authority. When my replace-via-z39.50 changed the 150$a in my authority, its title changed as expected. Or did you mean something other than the title of the authority itself? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #11 from Florian <florian.bontemps@biblibre.com> --- My apologies, it seems part of the testing plan got lost in translation on my side! Disregard my previous comment. (In reply to Andrew Fuerste-Henry from comment #10)
(In reply to Florian from comment #8)
Does not seem to work. When replacing created authority with Z39.50/SRU after patch, it does replace the details of the authority but it does not change its title.
I'm not sure I understand the issue you ran into. I tested this with a topical term subject authority. When my replace-via-z39.50 changed the 150$a in my authority, its title changed as expected. Or did you mean something other than the title of the authority itself?
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126178|0 |1 is obsolete| | --- Comment #12 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 126594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126594&action=edit Bug28573: Replace authority record with Z39.50/SRU creates new authority record When trying to replace an authority record with Z39.50/SRU then a new authority record is created without deleting the old one and not link the new one with any record. This patch fixes that. Test plan: 1) Try to catalogue a new authority record from cataloguing form. 2) Try to replace that authority record with Z39.50/SRU, then a new authority record is created and also you have that one that you tried to replace. 3) Apply the patch. 4) Try to replace the authority from step1 with Z39.50/SRU, then is working as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Eric Phetteplace <phette23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127174&action=edit Bug 28573: Replace authority record with Z39.50/SRU creates new authority record When trying to replace an authority record with Z39.50/SRU then a new authority record is created without deleting the old one and not link the new one with any record. This patch fixes that. Test plan: 1) Try to catalogue a new authority record from cataloguing form. 2) Try to replace that authority record with Z39.50/SRU, then a new authority record is created and also you have that one that you tried to replace. 3) Apply the patch. 4) Try to replace the authority from step1 with Z39.50/SRU, then is working as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Eric Phetteplace <phette23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work.. Works as expected, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham@catalyst.net.n | |z, kyle.m.hall@gmail.com, | |nick@bywatersolutions.com --- Comment #16 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Hello, As this is a major bug and the button doesn't do as it says, could this please be backported to 21.05.x? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Rhonda Kuiper <rkuiper@roundrocktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov --- Comment #17 from Rhonda Kuiper <rkuiper@roundrocktexas.gov> --- Please backport this to 21.05. The problem fixed by this bug is creating a lot of extra work for our catalogers that we didn't have to do when we were on 20.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #19 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- (In reply to Kyle M Hall from comment #18)
Pushed to 21.05.x for 21.05.05
21.05.06? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |23302 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23302 [Bug 23302] Less clicks on Z3950 search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28573 --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 23302 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org