[Bug 19198] New: Renewal as issue causes too many error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Bug ID: 19198 Summary: Renewal as issue causes too many error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too many' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66584&action=edit Bug 19198 - Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66585&action=edit Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66584|0 |1 is obsolete| | --- Comment #3 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 66670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66670&action=edit Bug 19198 - Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #4 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 66671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66671&action=edit Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66585|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- cd t/db_dependent/; git grep -l CanBookBeIssued | xargs prove not ok 8 - Not a specific case, $delta should not be incremented # Failed test 'Not a specific case, $delta should not be incremented' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 146. # got: undef # expected: 'TOO_MANY_CHECKOUTS' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66670|0 |1 is obsolete| | Attachment #66671|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67111&action=edit Bug 19198 - Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67112&action=edit Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67113&action=edit Bug 19198 (QA Followup) Fix typo in conditions '&' should be '&&' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Sorry Nick, can you rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67111|0 |1 is obsolete| | Attachment #67112|0 |1 is obsolete| | Attachment #67113|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67567&action=edit Bug 19198 - Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67568&action=edit Bug 19198 - Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 67569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67569&action=edit Bug 19198 (QA Followup) Fix typo in conditions '&' should be '&&' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67567|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67571&action=edit Bug 19198: Unit tests Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67568|0 |1 is obsolete| | --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67572&action=edit Bug 19198: Renewal as issue causes too many error This patch moves some code and prevents checking for too many checkouts when performing a renewal via checkout To test: 1 - Set a rule to limit checkouts to a single issue, allowing renewal 2 - Issue an item to a patron 3 - Issue the same item 4 - In staff client you get a confirm to renew and a notice of Too Many checkouts, don't confirm 5 - VIA Sip - you get a renewal response, but in logs the renewal fails as a 'too 6 - Apply patch 7 - Via staff client you shoudl get renewal confirm with no too many error 8 - SIP checkout should renew Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67569|0 |1 is obsolete| | --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67573&action=edit Bug 19198: (QA followup) Fix typo in conditions '&' should be '&&' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- I think Tomas just didn't change status, revert if I am wrong :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67719&action=edit Bug 19198: do not autovivify -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67720&action=edit Bug 19198: Prevent the test to fail randomly If categorycode is 'X', the test will fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org